Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: gpu/command_buffer/service/feature_info.h

Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context (Closed)
Patch Set: remove runtime flag unsafeES3APIs from blink webgl module Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info.h
diff --git a/gpu/command_buffer/service/feature_info.h b/gpu/command_buffer/service/feature_info.h
index 750c816ad77b31d2205a8517fc6ba238d6893270..c9931138beaf6e854a4d26bad5061dfdb18972af 100644
--- a/gpu/command_buffer/service/feature_info.h
+++ b/gpu/command_buffer/service/feature_info.h
@@ -144,7 +144,15 @@ class GPU_EXPORT FeatureInfo : public base::RefCounted<FeatureInfo> {
void EnableES3Validators();
bool IsES3Enabled() const {
- return unsafe_es3_apis_enabled_;
+ return es3_apis_enabled_;
+ }
+
+ void SetES3APIsSwitch(bool enabled) {
+ enable_es3_apis_switch_ = enabled;
+ }
+
+ bool GetES3APIsSwitch() const {
+ return enable_es3_apis_switch_;
}
bool disable_shader_translator() const { return disable_shader_translator_; }
@@ -193,9 +201,10 @@ class GPU_EXPORT FeatureInfo : public base::RefCounted<FeatureInfo> {
const GpuDriverBugWorkarounds workarounds_;
// Whether the command line switch kEnableUnsafeES3APIs is passed in.
- bool enable_unsafe_es3_apis_switch_;
+ // bool enable_unsafe_es3_apis_switch_;
- bool unsafe_es3_apis_enabled_;
+ bool es3_apis_enabled_;
+ bool enable_es3_apis_switch_;
bool chromium_color_buffer_float_rgba_available_;
bool chromium_color_buffer_float_rgb_available_;

Powered by Google App Engine
This is Rietveld 408576698