gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc - Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context (Closed)

Patch Set: fix a bug Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

index ba58f9f340581599b68f5b0fa41396a375ee5f1a..b2980f1c7d7607aa02eaa8431d5ab8ad11486847 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

@@ -919,7 +919,6 @@ TEST_P(GLES2DecoderManualInitTest, ReadPixels2RowLengthWorkaround) {

command_line.AppendSwitchASCII(

switches::kGpuDriverBugWorkarounds,

base::IntToString(gpu::PACK_PARAMETERS_WORKAROUND_WITH_PACK_BUFFER));

- command_line.AppendSwitch(switches::kEnableUnsafeES3APIs);

InitState init;

init.gl_version = "OpenGL ES 3.0";

init.bind_generates_resource = true;

@@ -973,7 +972,6 @@ TEST_P(GLES2DecoderManualInitTest, ReadPixels2AlignmentWorkaround) {

command_line.AppendSwitchASCII(

switches::kGpuDriverBugWorkarounds,

base::IntToString(gpu::PACK_PARAMETERS_WORKAROUND_WITH_PACK_BUFFER));

- command_line.AppendSwitch(switches::kEnableUnsafeES3APIs);

InitState init;

init.gl_version = "OpenGL ES 3.0";

init.bind_generates_resource = true;

@@ -1029,7 +1027,6 @@ TEST_P(GLES2DecoderManualInitTest,

command_line.AppendSwitchASCII(

switches::kGpuDriverBugWorkarounds,

base::IntToString(gpu::PACK_PARAMETERS_WORKAROUND_WITH_PACK_BUFFER));

- command_line.AppendSwitch(switches::kEnableUnsafeES3APIs);

InitState init;

init.gl_version = "OpenGL ES 3.0";

init.bind_generates_resource = true;