Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc

Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context (Closed)
Patch Set: fix a bug Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 2106 matching lines...) Expand 10 before | Expand all | Expand 10 after
2117 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 2117 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
2118 cmd.Init(client_program_id_, 2118 cmd.Init(client_program_id_,
2119 kBucketId, 2119 kBucketId,
2120 kSharedMemoryId, 2120 kSharedMemoryId,
2121 kInvalidSharedMemoryOffset); 2121 kInvalidSharedMemoryOffset);
2122 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 2122 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
2123 } 2123 }
2124 2124
2125 TEST_P(GLES3DecoderWithShaderTest, Basic) { 2125 TEST_P(GLES3DecoderWithShaderTest, Basic) {
2126 // Make sure the setup is correct for ES3. 2126 // Make sure the setup is correct for ES3.
2127 EXPECT_TRUE(decoder_->unsafe_es3_apis_enabled()); 2127 EXPECT_TRUE(decoder_->es3_apis_enabled());
2128 EXPECT_TRUE(feature_info()->validators()->texture_bind_target.IsValid( 2128 EXPECT_TRUE(feature_info()->validators()->texture_bind_target.IsValid(
2129 GL_TEXTURE_3D)); 2129 GL_TEXTURE_3D));
2130 } 2130 }
2131 2131
2132 TEST_P(GLES3DecoderWithShaderTest, UniformBlockBindingValidArgs) { 2132 TEST_P(GLES3DecoderWithShaderTest, UniformBlockBindingValidArgs) {
2133 EXPECT_CALL(*gl_, UniformBlockBinding(kServiceProgramId, 1, 3)); 2133 EXPECT_CALL(*gl_, UniformBlockBinding(kServiceProgramId, 1, 3));
2134 SpecializedSetup<UniformBlockBinding, 0>(true); 2134 SpecializedSetup<UniformBlockBinding, 0>(true);
2135 UniformBlockBinding cmd; 2135 UniformBlockBinding cmd;
2136 cmd.Init(client_program_id_, 1, 3); 2136 cmd.Init(client_program_id_, 1, 3);
2137 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd)); 2137 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
2266 } 2266 }
2267 2267
2268 // TODO(gman): DeleteProgram 2268 // TODO(gman): DeleteProgram
2269 2269
2270 // TODO(gman): UseProgram 2270 // TODO(gman): UseProgram
2271 2271
2272 // TODO(gman): DeleteShader 2272 // TODO(gman): DeleteShader
2273 2273
2274 } // namespace gles2 2274 } // namespace gles2
2275 } // namespace gpu 2275 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698