Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2444793002: Allow custom security descriptors when creating named pipes on Windows. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), Matt Giuca, qsr+mojo_chromium.org, tapted, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow custom security descriptors when creating named pipes on Windows. Remoting requires control over the security descriptor used for its named pipes. This adds this as an option when creating server handles from named pipes on Windows. BUG=604282 Committed: https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3 Cr-Commit-Position: refs/heads/master@{#427266}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -32 lines) Patch
M chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/embedder/named_platform_channel_pair.h View 1 chunk +10 lines, -1 line 0 comments Download
M mojo/edk/embedder/named_platform_channel_pair_win.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/edk/embedder/named_platform_handle_utils.h View 1 chunk +20 lines, -4 lines 0 comments Download
M mojo/edk/embedder/named_platform_handle_utils_posix.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/embedder/named_platform_handle_utils_win.cc View 3 chunks +22 lines, -14 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 37 (30 generated)
Sam McNally
+thestig for //chrome +rockot for //mojo
4 years, 1 month ago (2016-10-24 23:25:28 UTC) #27
Lei Zhang
On 2016/10/24 23:25:28, Sam McNally wrote: > +thestig for //chrome > > +rockot for //mojo ...
4 years, 1 month ago (2016-10-24 23:45:20 UTC) #30
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-25 01:50:20 UTC) #31
Lei Zhang
lgtm BTW, android_clang_dbg_recipe has been acting up, so it's not you.
4 years, 1 month ago (2016-10-25 01:57:15 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444793002/160001
4 years, 1 month ago (2016-10-25 03:02:58 UTC) #34
commit-bot: I haz the power
Committed patchset #1 (id:160001)
4 years, 1 month ago (2016-10-25 03:39:44 UTC) #35
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 03:46:43 UTC) #37
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/404ec514001d24ae6e6d14495648645569f0bbd3
Cr-Commit-Position: refs/heads/master@{#427266}

Powered by Google App Engine
This is Rietveld 408576698