Add trace event for complete network request

third_party/WebKit/Source/platform/network/NetworkInstrumentation.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "platform/network/NetworkInstrumentation.h"
+
+#include "base/trace_event/trace_event.h"
+#include "wtf/text/CString.h"
+
+namespace network_instrumentation {
+
+using network_instrumentation::RequestOutcome;
+
+const char kBlinkResourceID[] = "BlinkResourceID";
+const char kResourceLoadTitle[] = "ResourceLoad";
+const char kNetInstrumentationCategory[] = TRACE_DISABLED_BY_DEFAULT("net.v2");
+
+const char* RequestOutcomeToString(RequestOutcome outcome) {
+  switch (outcome) {
+    case RequestOutcome::Success:
+      return "Success";
+    case RequestOutcome::Fail:
+      return "Fail";
+    default:
+      NOTREACHED();
+  }
+}
+
+ScopedResourceLoadTracker::ScopedResourceLoadTracker(
+    unsigned long resourceID,
+    const blink::ResourceRequest& request)
+    : closeSliceAtEndOfScope(true), resourceID(resourceID), request(request) {
+  beginResourceLoad(resourceID, request);
+}
+
+ScopedResourceLoadTracker::~ScopedResourceLoadTracker() {
+  if (this->closeSliceAtEndOfScope)
+    endResourceLoad(this->resourceID, RequestOutcome::Fail);
+}
+
+void ScopedResourceLoadTracker::doNotCloseSliceAtEndOfScope() {
+  this->closeSliceAtEndOfScope = false;
+}
+
+void beginResourceLoad(unsigned long resourceID,

[chiniforooshan, 2016/11/03 15:50:36]

Is it necessary to have this function? I would move the following to the
ScopedResourceLoadTracer constructor.

[dproy, 2016/11/03 16:27:19]

I moved it inside.

+                       const blink::ResourceRequest& request) {
+  const String urlString = request.url().getString();
+  TRACE_EVENT_NESTABLE_ASYNC_BEGIN1(
+      kNetInstrumentationCategory, kResourceLoadTitle,
+      TRACE_ID_WITH_SCOPE(kBlinkResourceID, TRACE_ID_LOCAL(resourceID)), "url",
+      TRACE_STR_COPY(urlString.utf8().data()));

[chiniforooshan, 2016/11/03 15:50:36]

is TRACE_STR_COPY(request.url().getString().utf8().data()) too long? If not,
write it all in one line and remove the include CString from the beginning.

[dproy, 2016/11/03 16:27:19]

Done.

+}
+
+void endResourceLoad(unsigned long resourceID, RequestOutcome outcome) {
+  TRACE_EVENT_NESTABLE_ASYNC_END1(
+      kNetInstrumentationCategory, kResourceLoadTitle,
+      TRACE_ID_WITH_SCOPE(kBlinkResourceID, TRACE_ID_LOCAL(resourceID)),
+      "outcome", TRACE_STR_COPY(RequestOutcomeToString(outcome)));
+}
+
+}  // namespace network_instrumentation