Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: components/prefs/value_map_pref_store.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/testing_pref_store.cc ('k') | components/proxy_config/pref_proxy_config_tracker_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/value_map_pref_store.cc
diff --git a/components/prefs/value_map_pref_store.cc b/components/prefs/value_map_pref_store.cc
index 15a0eb1e92b1d99e9e0535ad3b56294b6fc6652b..8b828b10d5c628cdc6b2bb9333269e0746554046 100644
--- a/components/prefs/value_map_pref_store.cc
+++ b/components/prefs/value_map_pref_store.cc
@@ -32,13 +32,17 @@ bool ValueMapPrefStore::HasObservers() const {
void ValueMapPrefStore::SetValue(const std::string& key,
std::unique_ptr<base::Value> value,
uint32_t flags) {
- if (prefs_.SetValue(key, std::move(value)))
- FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
+ if (prefs_.SetValue(key, std::move(value))) {
+ for (Observer& observer : observers_)
+ observer.OnPrefValueChanged(key);
+ }
}
void ValueMapPrefStore::RemoveValue(const std::string& key, uint32_t flags) {
- if (prefs_.RemoveValue(key))
- FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
+ if (prefs_.RemoveValue(key)) {
+ for (Observer& observer : observers_)
+ observer.OnPrefValueChanged(key);
+ }
}
bool ValueMapPrefStore::GetMutableValue(const std::string& key,
@@ -48,7 +52,8 @@ bool ValueMapPrefStore::GetMutableValue(const std::string& key,
void ValueMapPrefStore::ReportValueChanged(const std::string& key,
uint32_t flags) {
- FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
+ for (Observer& observer : observers_)
+ observer.OnPrefValueChanged(key);
}
void ValueMapPrefStore::SetValueSilently(const std::string& key,
@@ -60,5 +65,6 @@ void ValueMapPrefStore::SetValueSilently(const std::string& key,
ValueMapPrefStore::~ValueMapPrefStore() {}
void ValueMapPrefStore::NotifyInitializationCompleted() {
- FOR_EACH_OBSERVER(Observer, observers_, OnInitializationCompleted(true));
+ for (Observer& observer : observers_)
+ observer.OnInitializationCompleted(true);
}
« no previous file with comments | « components/prefs/testing_pref_store.cc ('k') | components/proxy_config/pref_proxy_config_tracker_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698