Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2880)

Unified Diff: components/prefs/json_pref_store.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/in_memory_pref_store.cc ('k') | components/prefs/overlay_user_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/json_pref_store.cc
diff --git a/components/prefs/json_pref_store.cc b/components/prefs/json_pref_store.cc
index 811d2be07879e0de7628d4772b8790a37c239578..4076433dbb84dcb9c3c5b2295ad70693b5b78cba 100644
--- a/components/prefs/json_pref_store.cc
+++ b/components/prefs/json_pref_store.cc
@@ -320,7 +320,8 @@ void JsonPrefStore::ReportValueChanged(const std::string& key, uint32_t flags) {
if (pref_filter_)
pref_filter_->FilterUpdate(key);
- FOR_EACH_OBSERVER(PrefStore::Observer, observers_, OnPrefValueChanged(key));
+ for (PrefStore::Observer& observer : observers_)
+ observer.OnPrefValueChanged(key);
ScheduleWrite(flags);
}
@@ -488,9 +489,8 @@ void JsonPrefStore::FinalizeFileRead(
filtering_in_progress_ = false;
if (!initialization_successful) {
- FOR_EACH_OBSERVER(PrefStore::Observer,
- observers_,
- OnInitializationCompleted(false));
+ for (PrefStore::Observer& observer : observers_)
+ observer.OnInitializationCompleted(false);
return;
}
@@ -504,9 +504,8 @@ void JsonPrefStore::FinalizeFileRead(
if (error_delegate_ && read_error_ != PREF_READ_ERROR_NONE)
error_delegate_->OnError(read_error_);
- FOR_EACH_OBSERVER(PrefStore::Observer,
- observers_,
- OnInitializationCompleted(true));
+ for (PrefStore::Observer& observer : observers_)
+ observer.OnInitializationCompleted(true);
return;
}
« no previous file with comments | « components/prefs/in_memory_pref_store.cc ('k') | components/prefs/overlay_user_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698