Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: components/omnibox/browser/shortcuts_backend.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/shortcuts_backend.cc
diff --git a/components/omnibox/browser/shortcuts_backend.cc b/components/omnibox/browser/shortcuts_backend.cc
index c7534ee4f5faeec843af304a73566b0e62259e36..b34cd402b65647ede02803dfd061bcf342570811 100644
--- a/components/omnibox/browser/shortcuts_backend.cc
+++ b/components/omnibox/browser/shortcuts_backend.cc
@@ -228,8 +228,8 @@ void ShortcutsBackend::InitCompleted() {
UMA_HISTOGRAM_COUNTS_10000("ShortcutsProvider.DatabaseSize",
shortcuts_map_.size());
current_state_ = INITIALIZED;
- FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
- OnShortcutsLoaded());
+ for (ShortcutsBackendObserver& observer : observer_list_)
+ observer.OnShortcutsLoaded();
}
bool ShortcutsBackend::AddShortcut(
@@ -239,8 +239,8 @@ bool ShortcutsBackend::AddShortcut(
DCHECK(guid_map_.find(shortcut.id) == guid_map_.end());
guid_map_[shortcut.id] = shortcuts_map_.insert(
std::make_pair(base::i18n::ToLower(shortcut.text), shortcut));
- FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
- OnShortcutsChanged());
+ for (ShortcutsBackendObserver& observer : observer_list_)
+ observer.OnShortcutsChanged();
return no_db_access_ ||
db_runner_->PostTask(
FROM_HERE,
@@ -257,8 +257,8 @@ bool ShortcutsBackend::UpdateShortcut(
shortcuts_map_.erase(it->second);
guid_map_[shortcut.id] = shortcuts_map_.insert(
std::make_pair(base::i18n::ToLower(shortcut.text), shortcut));
- FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
- OnShortcutsChanged());
+ for (ShortcutsBackendObserver& observer : observer_list_)
+ observer.OnShortcutsChanged();
return no_db_access_ ||
db_runner_->PostTask(
FROM_HERE,
@@ -277,8 +277,8 @@ bool ShortcutsBackend::DeleteShortcutsWithIDs(
guid_map_.erase(it);
}
}
- FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
- OnShortcutsChanged());
+ for (ShortcutsBackendObserver& observer : observer_list_)
+ observer.OnShortcutsChanged();
return no_db_access_ ||
db_runner_->PostTask(
FROM_HERE,
@@ -303,8 +303,8 @@ bool ShortcutsBackend::DeleteShortcutsWithURL(const GURL& url,
++it;
}
}
- FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
- OnShortcutsChanged());
+ for (ShortcutsBackendObserver& observer : observer_list_)
+ observer.OnShortcutsChanged();
return no_db_access_ ||
db_runner_->PostTask(
FROM_HERE,
@@ -318,8 +318,8 @@ bool ShortcutsBackend::DeleteAllShortcuts() {
return false;
shortcuts_map_.clear();
guid_map_.clear();
- FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
- OnShortcutsChanged());
+ for (ShortcutsBackendObserver& observer : observer_list_)
+ observer.OnShortcutsChanged();
return no_db_access_ ||
db_runner_->PostTask(
FROM_HERE, base::Bind(base::IgnoreResult(
« no previous file with comments | « components/omnibox/browser/omnibox_popup_model.cc ('k') | components/pairing/bluetooth_controller_pairing_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698