Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index eaa4cfa36a103d6ba26e4828cd219e73c8d07a54..b8203c64cfebcda45af4f114cf1962f13cae83a7 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -790,7 +790,8 @@ void OfflinePageModelImpl::OnAddOfflinePageDone(
}
DeletePendingArchiver(archiver);
- FOR_EACH_OBSERVER(Observer, observers_, OfflinePageModelChanged(this));
+ for (Observer& observer : observers_)
+ observer.OfflinePageModelChanged(this);
}
void OfflinePageModelImpl::OnMarkPageAccesseDone(
@@ -838,7 +839,8 @@ void OfflinePageModelImpl::OnLoadDone(
delayed_task.Run();
delayed_tasks_.clear();
- FOR_EACH_OBSERVER(Observer, observers_, OfflinePageModelLoaded(this));
+ for (Observer& observer : observers_)
+ observer.OfflinePageModelLoaded(this);
CheckMetadataConsistency();
@@ -947,8 +949,8 @@ void OfflinePageModelImpl::OnRemoveOfflinePagesDone(
}
for (const auto& page : result->updated_items) {
- FOR_EACH_OBSERVER(Observer, observers_,
- OfflinePageDeleted(page.offline_id, page.client_id));
+ for (Observer& observer : observers_)
+ observer.OfflinePageDeleted(page.offline_id, page.client_id);
}
// TODO(fgorski): React the FAILED_INITIALIZATION, FAILED_RESET here.
« no previous file with comments | « components/offline_pages/downloads/download_ui_adapter.cc ('k') | components/omnibox/browser/omnibox_popup_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698