Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2444753002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/downloads/download_ui_adapter.cc
diff --git a/components/offline_pages/downloads/download_ui_adapter.cc b/components/offline_pages/downloads/download_ui_adapter.cc
index d095ec33e810d0a17ed7d4c90d1263435ae33d52..bb398cb8f025d372546d0d669b1137e76a555acd 100644
--- a/components/offline_pages/downloads/download_ui_adapter.cc
+++ b/components/offline_pages/downloads/download_ui_adapter.cc
@@ -96,7 +96,8 @@ void DownloadUIAdapter::OfflinePageDeleted(
if (it == items_.end())
return;
items_.erase(it);
- FOR_EACH_OBSERVER(Observer, observers_, ItemDeleted(guid));
+ for (Observer& observer : observers_)
+ observer.ItemDeleted(guid);
}
std::vector<const DownloadUIItem*> DownloadUIAdapter::GetAllItems() const {
@@ -175,7 +176,8 @@ void DownloadUIAdapter::OnOfflinePagesLoaded(
}
model_->AddObserver(this);
state_ = State::LOADED;
- FOR_EACH_OBSERVER(Observer, observers_, ItemsLoaded());
+ for (Observer& observer : observers_)
+ observer.ItemsLoaded();
}
void DownloadUIAdapter::NotifyItemsLoaded(Observer* observer) {
@@ -200,7 +202,8 @@ void DownloadUIAdapter::OnOfflinePagesChanged(
}
for (auto& guid : added_guids) {
const DownloadUIItem& item = *(items_.find(guid)->second->ui_item.get());
- FOR_EACH_OBSERVER(Observer, observers_, ItemAdded(item));
+ for (Observer& observer : observers_)
+ observer.ItemAdded(item);
}
}
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/offline_page_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698