Remove NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/e/api

Remove NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/e/api

cleaning up : download, omnibox, settings_overrides, spellcheck, stream_private API.

BUG=354046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266275

[limasdf, 2014-04-24 17:28:44]

PTAL. I'm going to kill easy things first. unfortunately they don't have OWNER.

[benjhayden, 2014-04-24 17:38:48]

downloads/ LGTM with 2 nits.

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/downloads/downloads_api.cc (right):

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.cc:1908: if (iter !=
shelf_disabling_extensions_.end())
Is the indentation correct here? I can't tell.

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/downloads/downloads_api.h (right):

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.h:393: virtual void
OnExtensionUnloaded(
// extensions::ExtensionRegistryObserver

[not at google - send to devlin, 2014-04-24 17:43:41]

lgtm, the 2 comments I made in downloads_api could be applied to other files
too.

the indentation is fine so long as you run "git cl format".

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/downloads/downloads_api.h (right):

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.h:25: #include
"content/public/browser/notification_registrar.h"
you can delete these #includes

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.h:404:
scoped_extension_registry_observer_;
no scoped_

[limasdf, 2014-04-24 17:46:47]

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/spellcheck/spellcheck_api.cc (right):

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/spellcheck/spellcheck_api.cc:13: #include
"content/public/browser/notification_details.h"
I think i can kill this includes. will upload soon.

[limasdf, 2014-04-24 18:27:46]

Thanks for the review. Updated. committing then...

- Run 'git cl format'
- Removed unwanted #include
- Removed scoped_

@benjhayden I forgot you from the OWNER. Sorry about that.

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/downloads/downloads_api.cc (right):

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.cc:1908: if (iter !=
shelf_disabling_extensions_.end())
On 2014/04/24 17:38:48, benjhayden_chromium wrote:
> Is the indentation correct here? I can't tell.

My bad. Done.

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/downloads/downloads_api.h (right):

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.h:25: #include
"content/public/browser/notification_registrar.h"
On 2014/04/24 17:43:41, kalman wrote:
> you can delete these #includes

Done. not only here but also others.

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.h:393: virtual void
OnExtensionUnloaded(
On 2014/04/24 17:38:48, benjhayden_chromium wrote:
> // extensions::ExtensionRegistryObserver

Done.

https://codereview.chromium.org/244473002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/downloads/downloads_api.h:404:
scoped_extension_registry_observer_;
On 2014/04/24 17:43:41, kalman wrote:
> no scoped_

Done. my bad

[limasdf, 2014-04-24 18:30:58]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-24 21:52:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/244473002/130001

[commit-bot: I haz the power, 2014-04-24 23:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:53:00]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[limasdf, 2014-04-25 02:20:56]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-25 02:21:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/244473002/130001

[commit-bot: I haz the power, 2014-04-25 03:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 03:28:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[limasdf, 2014-04-25 03:31:36]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-25 03:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/244473002/130001

[commit-bot: I haz the power, 2014-04-25 23:12:35]

Change committed as 266275