Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 24447003: add counting to glyphcache, and refactor some for clarity (Closed)

Created:
7 years, 3 months ago by reed1
Modified:
7 years, 2 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com, mtklein
Visibility:
Public.

Description

add counting to Globals, and refactor some for clarity BUG= Committed: https://code.google.com/p/skia/source/detail?r=11484

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Total comments: 4

Patch Set 3 : expose count-limit in SkGraphics.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -178 lines) Patch
M gyp/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkGraphics.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M src/core/SkGlyphCache.h View 1 2 chunks +0 lines, -24 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 1 2 11 chunks +144 lines, -154 lines 0 comments Download
A src/core/SkGlyphCache_Globals.h View 1 2 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
7 years, 3 months ago (2013-09-24 21:56:37 UTC) #1
bungeman-skia
https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp#newcode619 src/core/SkGlyphCache.cpp:619: sk_atomic_inc(&fCacheCount); This is going to set off the chromium ...
7 years, 2 months ago (2013-09-25 14:46:07 UTC) #2
reed1
https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp#newcode619 src/core/SkGlyphCache.cpp:619: sk_atomic_inc(&fCacheCount); On 2013/09/25 14:46:07, bungeman1 wrote: > This is ...
7 years, 2 months ago (2013-09-25 17:30:31 UTC) #3
mtklein
https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp#newcode619 src/core/SkGlyphCache.cpp:619: sk_atomic_inc(&fCacheCount); On 2013/09/25 17:30:31, reed1 wrote: > On 2013/09/25 ...
7 years, 2 months ago (2013-09-25 18:15:25 UTC) #4
bungeman-skia
https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/24447003/diff/1/src/core/SkGlyphCache.cpp#newcode619 src/core/SkGlyphCache.cpp:619: sk_atomic_inc(&fCacheCount); On 2013/09/25 17:30:31, reed1 wrote: > On 2013/09/25 ...
7 years, 2 months ago (2013-09-25 22:37:08 UTC) #5
reed1
ptal
7 years, 2 months ago (2013-09-26 18:26:42 UTC) #6
bungeman-skia
https://codereview.chromium.org/24447003/diff/10001/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/24447003/diff/10001/src/core/SkGlyphCache.cpp#newcode19 src/core/SkGlyphCache.cpp:19: #define SPEW_PURGE_STATUS Spew!!! https://codereview.chromium.org/24447003/diff/10001/src/core/SkGlyphCache_Globals.h File src/core/SkGlyphCache_Globals.h (right): https://codereview.chromium.org/24447003/diff/10001/src/core/SkGlyphCache_Globals.h#newcode67 src/core/SkGlyphCache_Globals.h:67: ...
7 years, 2 months ago (2013-09-26 18:40:27 UTC) #7
reed1
https://codereview.chromium.org/24447003/diff/10001/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/24447003/diff/10001/src/core/SkGlyphCache.cpp#newcode19 src/core/SkGlyphCache.cpp:19: #define SPEW_PURGE_STATUS On 2013/09/26 18:40:27, bungeman1 wrote: > Spew!!! ...
7 years, 2 months ago (2013-09-26 19:17:14 UTC) #8
reed1
7 years, 2 months ago (2013-09-26 19:28:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r11484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698