Move MediaKeys::Exception to CdmPromise::Exception

Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706
Committed: https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680
Cr-Commit-Position: refs/heads/master@{#428061}

[dhna, 2016-10-22 18:23:52]

Description was changed from

==========
Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706
==========

to

==========
Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706
==========

[dhna, 2016-10-22 18:23:52]

corona10@gmail.com changed reviewers:
+ xhwang@chromium.org

[dhna, 2016-10-22 18:24:14]

@xhwang
PTAL

[dhna, 2016-10-22 18:42:51]

corona10@gmail.com changed reviewers:
+ sandersd@chromium.org

[simonhong, 2016-10-23 03:41:40]

The CQ bit was checked by simonhong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 03:41:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 03:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 03:55:21]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[simonhong, 2016-10-23 09:06:01]

The CQ bit was checked by simonhong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 09:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 09:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 09:16:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dhna, 2016-10-23 13:53:18]

The CQ bit was checked by corona10@gmail.com

[commit-bot: I haz the power, 2016-10-23 13:53:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 13:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 13:53:32]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dhna, 2016-10-23 13:53:33]

The CQ bit was unchecked by corona10@gmail.com

[simonhong, 2016-10-23 14:46:50]

The CQ bit was checked by simonhong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 14:46:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 15:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 15:25:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[simonhong, 2016-10-23 15:52:29]

The CQ bit was checked by simonhong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 15:52:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dhna, 2016-10-23 17:44:23]

On 2016/10/23 13:53:32, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

@xhwang, sandersd
PTAL

[commit-bot: I haz the power, 2016-10-23 17:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 17:54:51]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[xhwang, 2016-10-24 17:06:14]

Thank you so much for working on this. The change looking mostly good. I just
have some minor comments, mostly on obsolete "media_keys.h" header includes.

https://codereview.chromium.org/2444683002/diff/180001/content/renderer/peppe...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/2444683002/diff/180001/content/renderer/peppe...
content/renderer/pepper/content_decryptor_delegate.cc:293: CdmPromise::Exception
PpExceptionTypeToMediaException(
Please also update the function name.

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_callbac...
File media/base/cdm_callback_promise.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_callbac...
media/base/cdm_callback_promise.h:16: #include "media/base/media_keys.h"
remove this include?

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_initial...
File media/base/cdm_initialized_promise.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_initial...
media/base/cdm_initialized_promise.h:14: #include "media/base/media_keys.h"
nit: You can forward declare MediaKeys and remove this include now.

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise.h
File media/base/cdm_promise.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise...
media/base/cdm_promise.h:15: #include "media/base/media_keys.h"
ditto about removing this include

https://codereview.chromium.org/2444683002/diff/180001/media/blink/cdm_result...
File media/blink/cdm_result_promise.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/blink/cdm_result...
media/blink/cdm_result_promise.h:12: #include "media/base/media_keys.h"
ditto

https://codereview.chromium.org/2444683002/diff/180001/media/blink/cdm_result...
File media/blink/cdm_result_promise_helper.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/blink/cdm_result...
media/blink/cdm_result_promise_helper.h:11: #include "media/base/media_keys.h"
ditto

https://codereview.chromium.org/2444683002/diff/180001/media/blink/new_sessio...
File media/blink/new_session_cdm_result_promise.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/blink/new_sessio...
media/blink/new_session_cdm_result_promise.h:14: #include
"media/base/media_keys.h"
ditto

https://codereview.chromium.org/2444683002/diff/180001/media/cdm/aes_decrypto...
File media/cdm/aes_decryptor.cc (left):

https://codereview.chromium.org/2444683002/diff/180001/media/cdm/aes_decrypto...
media/cdm/aes_decryptor.cc:32: 
We actually like this empty line :)

https://codereview.chromium.org/2444683002/diff/180001/media/cdm/aes_decryptor.h
File media/cdm/aes_decryptor.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/cdm/aes_decrypto...
media/cdm/aes_decryptor.h:20: #include "media/base/cdm_promise.h"
It seems you only need this in the .cc file.

https://codereview.chromium.org/2444683002/diff/180001/media/mojo/clients/moj...
File media/mojo/clients/mojo_cdm.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/mojo/clients/moj...
media/mojo/clients/mojo_cdm.h:20: #include "media/base/cdm_promise.h"
ditto, only include in .cc file

https://codereview.chromium.org/2444683002/diff/180001/media/mojo/services/mo...
File media/mojo/services/mojo_cdm_promise.cc (right):

https://codereview.chromium.org/2444683002/diff/180001/media/mojo/services/mo...
media/mojo/services/mojo_cdm_promise.cc:14: #include "media/base/media_keys.h"
remove?

[xhwang, 2016-10-24 17:34:23]

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise.h
File media/base/cdm_promise.h (right):

https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise...
media/base/cdm_promise.h:36: // http://crbug.com/249976
Also, this comment is not accurate now. Could you please update it to:

TODO(jrummell): Remove deprecated errors. See http://crbug.com/570216#c11

Thanks!

[dhna, 2016-10-24 23:43:53]

On 2016/10/24 17:34:23, xhwang wrote:
>
https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise.h
> File media/base/cdm_promise.h (right):
> 
>
https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise...
> media/base/cdm_promise.h:36: // http://crbug.com/249976
> Also, this comment is not accurate now. Could you please update it to:
> 
> TODO(jrummell): Remove deprecated errors. See http://crbug.com/570216#c11
> 
> Thanks!

@xhwang
Done. But I think we should check with trybot.
Anyway PTAL.

[dhna, 2016-10-24 23:44:22]

On 2016/10/24 23:43:53, dhna wrote:
> On 2016/10/24 17:34:23, xhwang wrote:
> >
>
https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise.h
> > File media/base/cdm_promise.h (right):
> > 
> >
>
https://codereview.chromium.org/2444683002/diff/180001/media/base/cdm_promise...
> > media/base/cdm_promise.h:36: // http://crbug.com/249976
> > Also, this comment is not accurate now. Could you please update it to:
> > 
> > TODO(jrummell): Remove deprecated errors. See http://crbug.com/570216#c11
> > 
> > Thanks!
> 
> @xhwang
> Done. But I think we should check with trybot.
> Anyway PTAL.

@xhwang
Done. But I think we should check with build bot.
Anyway PTAL.

[xhwang, 2016-10-25 08:01:18]

LGTM

Thank you again for working on this!

[dhna, 2016-10-25 08:36:38]

The CQ bit was checked by corona10@gmail.com

[commit-bot: I haz the power, 2016-10-25 08:37:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dhna, 2016-10-25 08:37:07]

On 2016/10/25 08:01:18, xhwang wrote:
> LGTM
> 
> Thank you again for working on this!

@xhwang
Thank you review commit :-)

[dhna, 2016-10-25 08:37:16]

On 2016/10/25 08:01:18, xhwang wrote:
> LGTM
> 
> Thank you again for working on this!

@xhwang
Thank you review my commit :-)

[commit-bot: I haz the power, 2016-10-25 09:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 09:45:06]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dhna, 2016-10-25 09:56:41]

On 2016/10/25 09:45:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_clang on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

@xhwang
Only on windows failed to compile. I m not using windows can I know why this
happen? It looks like we duplicated declare somthing.

[dhna, 2016-10-25 12:49:22]

corona10@gmail.com changed reviewers:
+ jam@chromium.org, meacer@chromium.org

[dhna, 2016-10-25 12:51:10]

On 2016/10/25 09:56:41, dhna wrote:
> On 2016/10/25 09:45:06, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_clang on master.tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
> 
> @xhwang
> Only on windows failed to compile. I m not using windows can I know why this
> happen? It looks like we duplicated declare somthing.

@jam
Can you review for
chromecast/media/cdm/cast_cdm_proxy.cc
content/renderer/media/cdm/ppapi_decryptor.cc 

@Mustafa Emre Acer
Can you review for
media/base/ipc/media_param_traits_macros.h
media/mojo/interfaces/content_decryption_module.mojom
?

[dhna, 2016-10-25 13:28:31]

The CQ bit was checked by corona10@gmail.com

[dhna, 2016-10-25 13:28:32]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2444683002/#ps240001
(title: "remove header")

[commit-bot: I haz the power, 2016-10-25 13:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 13:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 13:37:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dhna, 2016-10-25 13:50:55]

On 2016/10/25 13:37:10, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

summary
@xhwang
Only on windows failed to compile. 
I m not using windows. 
Can I know why this happen? 
It looks like we include duplicate header somthing but I don't know which one.

@jam
Can you review for
chromecast/media/cdm/cast_cdm_proxy.cc
content/renderer/media/cdm/ppapi_decryptor.cc 

@Mustafa Emre Acer
Can you review for
media/base/ipc/media_param_traits_macros.h
media/mojo/interfaces/content_decryption_module.mojom

[dhna, 2016-10-25 15:18:28]

The CQ bit was checked by corona10@gmail.com

[dhna, 2016-10-25 15:18:29]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2444683002/#ps260001
(title: "remove
third_party/WebKit/public/platform/WebContentDecryptionModuleResult.h")

[commit-bot: I haz the power, 2016-10-25 15:18:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 15:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 15:25:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dhna, 2016-10-25 15:43:23]

The CQ bit was checked by corona10@gmail.com

[dhna, 2016-10-25 15:43:24]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2444683002/#ps280001
(title: "remove
third_party/WebKit/public/platform/WebContentDecryptionModuleResult.h")

[commit-bot: I haz the power, 2016-10-25 15:43:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 15:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 15:51:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dhna, 2016-10-25 16:20:27]

On 2016/10/25 15:51:58, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

summary
@xhwang
Only on windows failed to compile. 
I m not using windows. 
Can I know why this happen? 
It looks like we include duplicate header somthing but I don't know which one.

@jam
Can you review for
chromecast/media/cdm/cast_cdm_proxy.cc
content/renderer/media/cdm/ppapi_decryptor.cc 

@Mustafa Emre Acer
Can you review for
media/base/ipc/media_param_traits_macros.h
media/mojo/interfaces/content_decryption_module.mojom

[jam, 2016-10-25 19:16:48]

On 2016/10/25 16:20:27, dhna wrote:
> On 2016/10/25 15:51:58, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> summary
> @xhwang
> Only on windows failed to compile. 
> I m not using windows. 
> Can I know why this happen? 
> It looks like we include duplicate header somthing but I don't know which one.
> 
> @jam
> Can you review for
> chromecast/media/cdm/cast_cdm_proxy.cc
> content/renderer/media/cdm/ppapi_decryptor.cc 
lgtm
> 
> @Mustafa Emre Acer
> Can you review for
> media/base/ipc/media_param_traits_macros.h
> media/mojo/interfaces/content_decryption_module.mojom

[meacer, 2016-10-25 19:23:21]

media/base/ipc/media_param_traits_macros.h
media/mojo/interfaces/content_decryption_module.mojom
LGTM

[dhna, 2016-10-26 00:05:04]

On 2016/10/25 19:23:21, Mustafa Emre Acer wrote:
> media/base/ipc/media_param_traits_macros.h
> media/mojo/interfaces/content_decryption_module.mojom
> LGTM

@xhwang
We should revert including header file before patchset#11 and fix it for later
patch?
PTAL

[xhwang, 2016-10-26 00:12:30]

On 2016/10/26 00:05:04, dhna wrote:
> On 2016/10/25 19:23:21, Mustafa Emre Acer wrote:
> > media/base/ipc/media_param_traits_macros.h
> > media/mojo/interfaces/content_decryption_module.mojom
> > LGTM
> 
> @xhwang
> We should revert including header file before patchset#11 and fix it for later
> patch?
> PTAL

I am confused why PS10 was working but the latest one isn't. I'll take a look
tonight.

[xhwang, 2016-10-26 00:13:05]

nits when I was looking...

https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise.h
File media/base/cdm_promise.h (right):

https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise...
media/base/cdm_promise.h:61: virtual void reject(CdmPromise::Exception
exception_code,
nit: No need for "CdmPromise::" here.

https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise...
media/base/cdm_promise.h:105: virtual void reject(CdmPromise::Exception
exception_code,
ditto

https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise...
media/base/cdm_promise.h:131: reject(CdmPromise::INVALID_STATE_ERROR, 0,
message);
ditto

https://codereview.chromium.org/2444683002/diff/280001/media/blink/cdm_result...
File media/blink/cdm_result_promise.h (left):

https://codereview.chromium.org/2444683002/diff/280001/media/blink/cdm_result...
media/blink/cdm_result_promise.h:14: #include
"third_party/WebKit/public/platform/WebContentDecryptionModuleResult.h"
You should keep these headers since they are used in the class declaration.

[dhna, 2016-10-26 00:59:24]

On 2016/10/26 00:13:05, xhwang wrote:
> nits when I was looking...
> 
>
https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise.h
> File media/base/cdm_promise.h (right):
> 
>
https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise...
> media/base/cdm_promise.h:61: virtual void reject(CdmPromise::Exception
> exception_code,
> nit: No need for "CdmPromise::" here.
> 
>
https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise...
> media/base/cdm_promise.h:105: virtual void reject(CdmPromise::Exception
> exception_code,
> ditto
> 
>
https://codereview.chromium.org/2444683002/diff/280001/media/base/cdm_promise...
> media/base/cdm_promise.h:131: reject(CdmPromise::INVALID_STATE_ERROR, 0,
> message);
> ditto
> 
>
https://codereview.chromium.org/2444683002/diff/280001/media/blink/cdm_result...
> File media/blink/cdm_result_promise.h (left):
> 
>
https://codereview.chromium.org/2444683002/diff/280001/media/blink/cdm_result...
> media/blink/cdm_result_promise.h:14: #include
> "third_party/WebKit/public/platform/WebContentDecryptionModuleResult.h"
> You should keep these headers since they are used in the class declaration.

Done.

[dhna, 2016-10-26 04:09:38]

The CQ bit was checked by corona10@gmail.com

[dhna, 2016-10-26 04:09:39]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
jam@chromium.org, meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2444683002/#ps300001
(title: "nit fix.")

[commit-bot: I haz the power, 2016-10-26 04:09:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:13:58]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2016-10-26 20:27:33]

I tried on Windows and can reproduce the linking error. I guess this is related
to using the same template class across two libraries. 

I don't have time to dig into details right now. I can take another look later,
or you can try it on Windows if possible as well. Sorry for the trouble.

[dhna, 2016-10-27 01:22:20]

On 2016/10/26 20:27:33, xhwang wrote:
> I tried on Windows and can reproduce the linking error. I guess this is
related
> to using the same template class across two libraries. 
> 
> I don't have time to dig into details right now. I can take another look
later,
> or you can try it on Windows if possible as well. Sorry for the trouble.

@xhwang
I thinks we should remove  "media/base/cdm_promise.h" from
media/cdm/ppapi/external_clear_key/clear_key_cdm.h
and shoud add it to "media/cdm/aes_decryptor.h".
Whant do you think??
PTAL.

[dhna, 2016-10-27 01:26:23]

On 2016/10/27 01:22:20, dhna wrote:
> On 2016/10/26 20:27:33, xhwang wrote:
> > I tried on Windows and can reproduce the linking error. I guess this is
> related
> > to using the same template class across two libraries. 
> > 
> > I don't have time to dig into details right now. I can take another look
> later,
> > or you can try it on Windows if possible as well. Sorry for the trouble.
> 
> @xhwang
> I thinks we should remove  "media/base/cdm_promise.h" from
> media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> and shoud add it to "media/cdm/aes_decryptor.h".
> Whant do you think??
> PTAL.

@xhwang
I thinks we should remove  "media/base/cdm_promise.h" from
media/cdm/ppapi/external_clear_key/clear_key_cdm.h
and should add it to "media/cdm/aes_decryptor.h".
What do you think??
I can not test it for windows. I don't have enough test environment for windows.
I think I need to get permission to get build bot :-) LOL.
Can I execute dry run to test windows without commit patch?
PTAL.

[dhna, 2016-10-27 01:26:29]

On 2016/10/27 01:22:20, dhna wrote:
> On 2016/10/26 20:27:33, xhwang wrote:
> > I tried on Windows and can reproduce the linking error. I guess this is
> related
> > to using the same template class across two libraries. 
> > 
> > I don't have time to dig into details right now. I can take another look
> later,
> > or you can try it on Windows if possible as well. Sorry for the trouble.
> 
> @xhwang
> I thinks we should remove  "media/base/cdm_promise.h" from
> media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> and shoud add it to "media/cdm/aes_decryptor.h".
> Whant do you think??
> PTAL.

@xhwang
I think we should remove  "media/base/cdm_promise.h" from
media/cdm/ppapi/external_clear_key/clear_key_cdm.h
and should add it to "media/cdm/aes_decryptor.h".
What do you think??
I can not test it for windows. I don't have enough test environment for windows.
I think I need to get permission to get build bot :-) LOL.
Can I execute dry run to test windows without commit patch?
PTAL.

[dhna, 2016-10-27 01:28:13]

The CQ bit was checked by corona10@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 01:28:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dhna, 2016-10-27 01:55:57]

On 2016/10/27 01:26:29, dhna wrote:
> On 2016/10/27 01:22:20, dhna wrote:
> > On 2016/10/26 20:27:33, xhwang wrote:
> > > I tried on Windows and can reproduce the linking error. I guess this is
> > related
> > > to using the same template class across two libraries. 
> > > 
> > > I don't have time to dig into details right now. I can take another look
> > later,
> > > or you can try it on Windows if possible as well. Sorry for the trouble.
> > 
> > @xhwang
> > I thinks we should remove  "media/base/cdm_promise.h" from
> > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > and shoud add it to "media/cdm/aes_decryptor.h".
> > Whant do you think??
> > PTAL.
> 
> @xhwang
> I think we should remove  "media/base/cdm_promise.h" from
> media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> and should add it to "media/cdm/aes_decryptor.h".
> What do you think??
> I can not test it for windows. I don't have enough test environment for
windows.
> I think I need to get permission to get build bot :-) LOL.
> Can I execute dry run to test windows without commit patch?
> PTAL.

Not works. I think I should wait for until finding what is problem.

[dhna, 2016-10-27 02:14:04]

The CQ bit was checked by corona10@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 02:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dhna, 2016-10-27 02:42:00]

On 2016/10/27 01:55:57, dhna wrote:
> On 2016/10/27 01:26:29, dhna wrote:
> > On 2016/10/27 01:22:20, dhna wrote:
> > > On 2016/10/26 20:27:33, xhwang wrote:
> > > > I tried on Windows and can reproduce the linking error. I guess this is
> > > related
> > > > to using the same template class across two libraries. 
> > > > 
> > > > I don't have time to dig into details right now. I can take another look
> > > later,
> > > > or you can try it on Windows if possible as well. Sorry for the trouble.
> > > 
> > > @xhwang
> > > I thinks we should remove  "media/base/cdm_promise.h" from
> > > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > > and shoud add it to "media/cdm/aes_decryptor.h".
> > > Whant do you think??
> > > PTAL.
> > 
> > @xhwang
> > I think we should remove  "media/base/cdm_promise.h" from
> > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > and should add it to "media/cdm/aes_decryptor.h".
> > What do you think??
> > I can not test it for windows. I don't have enough test environment for
> windows.
> > I think I need to get permission to get build bot :-) LOL.
> > Can I execute dry run to test windows without commit patch?
> > PTAL.
> 
> Not works. I think I should wait for until finding what is problem.

@xhwang
It success to compile on Windows platform.
When I include  "media/base/media_keys.h" into "media/base/cdm_promise.h" and
"media/base/cdm_callback_promise.h"
PTAL.

[commit-bot: I haz the power, 2016-10-27 03:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 03:22:59]

Dry run: This issue passed the CQ dry run.

[dhna, 2016-10-27 07:26:30]

On 2016/10/27 02:42:00, dhna wrote:
> On 2016/10/27 01:55:57, dhna wrote:
> > On 2016/10/27 01:26:29, dhna wrote:
> > > On 2016/10/27 01:22:20, dhna wrote:
> > > > On 2016/10/26 20:27:33, xhwang wrote:
> > > > > I tried on Windows and can reproduce the linking error. I guess this
is
> > > > related
> > > > > to using the same template class across two libraries. 
> > > > > 
> > > > > I don't have time to dig into details right now. I can take another
look
> > > > later,
> > > > > or you can try it on Windows if possible as well. Sorry for the
trouble.
> > > > 
> > > > @xhwang
> > > > I thinks we should remove  "media/base/cdm_promise.h" from
> > > > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > > > and shoud add it to "media/cdm/aes_decryptor.h".
> > > > Whant do you think??
> > > > PTAL.
> > > 
> > > @xhwang
> > > I think we should remove  "media/base/cdm_promise.h" from
> > > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > > and should add it to "media/cdm/aes_decryptor.h".
> > > What do you think??
> > > I can not test it for windows. I don't have enough test environment for
> > windows.
> > > I think I need to get permission to get build bot :-) LOL.
> > > Can I execute dry run to test windows without commit patch?
> > > PTAL.
> > 
> > Not works. I think I should wait for until finding what is problem.
> 
> @xhwang
> It success to compile on Windows platform.
> When I include  "media/base/media_keys.h" into "media/base/cdm_promise.h" and
> "media/base/cdm_callback_promise.h"
> PTAL.

@xhwang
I wish commit it first. And
upload this issue and fix it later.

[xhwang, 2016-10-27 17:01:15]

On 2016/10/27 07:26:30, dhna wrote:
> On 2016/10/27 02:42:00, dhna wrote:
> > On 2016/10/27 01:55:57, dhna wrote:
> > > On 2016/10/27 01:26:29, dhna wrote:
> > > > On 2016/10/27 01:22:20, dhna wrote:
> > > > > On 2016/10/26 20:27:33, xhwang wrote:
> > > > > > I tried on Windows and can reproduce the linking error. I guess this
> is
> > > > > related
> > > > > > to using the same template class across two libraries. 
> > > > > > 
> > > > > > I don't have time to dig into details right now. I can take another
> look
> > > > > later,
> > > > > > or you can try it on Windows if possible as well. Sorry for the
> trouble.
> > > > > 
> > > > > @xhwang
> > > > > I thinks we should remove  "media/base/cdm_promise.h" from
> > > > > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > > > > and shoud add it to "media/cdm/aes_decryptor.h".
> > > > > Whant do you think??
> > > > > PTAL.
> > > > 
> > > > @xhwang
> > > > I think we should remove  "media/base/cdm_promise.h" from
> > > > media/cdm/ppapi/external_clear_key/clear_key_cdm.h
> > > > and should add it to "media/cdm/aes_decryptor.h".
> > > > What do you think??
> > > > I can not test it for windows. I don't have enough test environment for
> > > windows.
> > > > I think I need to get permission to get build bot :-) LOL.
> > > > Can I execute dry run to test windows without commit patch?
> > > > PTAL.
> > > 
> > > Not works. I think I should wait for until finding what is problem.
> > 
> > @xhwang
> > It success to compile on Windows platform.
> > When I include  "media/base/media_keys.h" into "media/base/cdm_promise.h"
and
> > "media/base/cdm_callback_promise.h"
> > PTAL.
> 
> @xhwang
> I wish commit it first. And
> upload this issue and fix it later.

I think it's still worth some more investigation to understand what's going on.
But what you are doing is basically maintaining the old behavior. So LGTM.

[dhna, 2016-10-27 17:02:11]

The CQ bit was checked by corona10@gmail.com

[dhna, 2016-10-27 17:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2444683002/#ps340001
(title: "include  "media/base/media_keys.h"")

[commit-bot: I haz the power, 2016-10-27 17:02:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 17:08:34]

Description was changed from

==========
Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706
==========

to

==========
Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706
==========

[commit-bot: I haz the power, 2016-10-27 17:08:35]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2016-10-27 17:31:03]

Description was changed from

==========
Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706
==========

to

==========
Move MediaKeys::Exception to CdmPromise::Exception

BUG=656706

Committed: https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680
Cr-Commit-Position: refs/heads/master@{#428061}
==========

[commit-bot: I haz the power, 2016-10-27 17:31:05]

Patchset 18 (id:??) landed as
https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680
Cr-Commit-Position: refs/heads/master@{#428061}