Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2444633002: Change ArchLinux httpd config to php7 (from php5) (Closed)

Created:
4 years, 2 months ago by robwu
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ArchLinux httpd config to php7 (from php5) ArchLinux's default PHP version is now PHP 7 instead of 5. This must be installed using: sudo pacman -S php-apache BUG=621694 TEST=Before this patch, run-webkit-tests did not work, after this patch it does. Committed: https://crrev.com/b4501f1a7771e0d22074e30ab3be3a9626adcd9e Cr-Commit-Position: refs/heads/master@{#427796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/conf/arch-httpd-2.4.conf View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robwu
4 years, 2 months ago (2016-10-22 00:27:37 UTC) #2
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-26 18:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444633002/1
4 years, 1 month ago (2016-10-26 19:55:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 21:18:08 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:20:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4501f1a7771e0d22074e30ab3be3a9626adcd9e
Cr-Commit-Position: refs/heads/master@{#427796}

Powered by Google App Engine
This is Rietveld 408576698