Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 244463003: Added "load stale" IDS grit variables to IOS whitelist. (Closed)

Created:
6 years, 8 months ago by Randy Smith (Not in Mondays)
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added "load stale" IDS grit variables to IOS whitelist. Needed for http://codereview.chromium.org/207553008 (r264696) to build on IOS. BUG=329621 R=rohitrao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Randy Smith (Not in Mondays)
Rohit: Willing to stamp this? I didn't include it in the original CL because I ...
6 years, 8 months ago (2014-04-20 22:37:22 UTC) #1
rohitrao (ping after 24h)
lgtm
6 years, 8 months ago (2014-04-20 22:42:59 UTC) #2
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 8 months ago (2014-04-20 22:44:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/244463003/1
6 years, 8 months ago (2014-04-20 22:44:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-20 23:41:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=173269
6 years, 8 months ago (2014-04-20 23:41:38 UTC) #6
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 8 months ago (2014-04-21 00:10:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/244463003/1
6 years, 8 months ago (2014-04-21 00:10:56 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 03:21:22 UTC) #9
Message was sent while issue was closed.
Change committed as 264963

Powered by Google App Engine
This is Rietveld 408576698