media: Rename ServiceFactory to InterfaceFactory

media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58
Cr-Commit-Position: refs/heads/master@{#427294}

[xhwang, 2016-10-22 00:13:36]

Description was changed from

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

BUG=657276
==========

to

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xhwang, 2016-10-22 00:13:50]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 00:14:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 02:07:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 02:07:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2016-10-22 02:31:05]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 02:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-22 02:36:38]

xhwang@chromium.org changed reviewers:
+ alokp@chromium.org, rockot@chromium.org, sandersd@chromium.org

[xhwang, 2016-10-22 02:36:38]

Another renaming CL. Other naming suggestions are more than welcome!

PTAL

[xhwang, 2016-10-22 02:39:31]

Another renaming CL. Other naming suggestions are more than welcome!

PTAL

[commit-bot: I haz the power, 2016-10-22 04:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 04:24:11]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-10-24 20:29:48]

The change itself is mechanical and lgtm.

The name choice is rather generic, but it is still an improvement.

I would still advocate removing the factory entirely and tying sessions together
with UnguessableTokens instead. OTOH, if we've entirely decided against that
plan we can move construction parameters to the factory methods instead and save
a round trip. We should decide a path there soon!

[xhwang, 2016-10-24 22:05:20]

On 2016/10/24 20:29:48, sandersd wrote:
> The change itself is mechanical and lgtm.
> 
> The name choice is rather generic, but it is still an improvement.
> 
> I would still advocate removing the factory entirely and tying sessions
together
> with UnguessableTokens instead. OTOH, if we've entirely decided against that
> plan we can move construction parameters to the factory methods instead and
save
> a round trip. We should decide a path there soon!

Thanks! I get your point. But now we actually need this class to receive
frame-based browser side services:

https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_...

There are probably other ways to achieve the same effect but I feel it's lower
priority...

UnguessableTokens is new to me, I'll take a look!

[Ken Rockot(use gerrit already), 2016-10-25 01:51:01]

rs lgtm

[xhwang, 2016-10-25 05:23:45]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-10-25 05:24:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-25 05:24:33]

Description was changed from

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xhwang, 2016-10-25 05:24:33]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org

[xhwang, 2016-10-25 05:25:12]

Description was changed from

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[xhwang, 2016-10-25 05:25:43]

TBRing dcheng@ for the renaming change in mojom.

[dcheng, 2016-10-25 05:27:21]

mojo lgtm

[commit-bot: I haz the power, 2016-10-25 07:06:24]

Description was changed from

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-25 07:06:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 07:08:52]

Description was changed from

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG=657276
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58
Cr-Commit-Position: refs/heads/master@{#427294}
==========

[commit-bot: I haz the power, 2016-10-25 07:08:54]

Patchset 2 (id:??) landed as
https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58
Cr-Commit-Position: refs/heads/master@{#427294}