Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 24446002: Port Pepper Audio API from the devsite. (Closed)

Created:
7 years, 3 months ago by Jim Stichnoth
Modified:
7 years, 2 months ago
Reviewers:
eliben, binji
CC:
chromium-reviews, native-client-reviews_googlegroups.com, binji, Sam Clegg
Visibility:
Public.

Description

Port Pepper Audio API from the devsite. BUG= none NOTRY=true (documentation-only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230244

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove SDK gallery refs and () instances #

Total comments: 16

Patch Set 3 : Code review changes #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -1 line) Patch
M native_client_sdk/src/doc/devguide/coding/audio.rst View 1 2 1 chunk +381 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/images/pepper-audio-api.png View Binary file 0 comments Download
M native_client_sdk/src/doc/images/pepper-audio-buffer.png View Binary file 0 comments Download

Messages

Total messages: 10 (0 generated)
Jim Stichnoth
I recreated the two images in Drive, and unintentionally overwrote the preexisting images of the ...
7 years, 3 months ago (2013-09-24 21:51:46 UTC) #1
eliben
lgtm with nits Ben: how do we know the code is still correct? https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/devguide/coding/audio.rst File ...
7 years, 2 months ago (2013-09-25 20:01:47 UTC) #2
Jim Stichnoth
PTAL. No committing until binji signoff. https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/devguide/coding/audio.rst File native_client_sdk/src/doc/devguide/coding/audio.rst (right): https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/devguide/coding/audio.rst#newcode32 native_client_sdk/src/doc/devguide/coding/audio.rst:32: TODO(stichnot): This is ...
7 years, 2 months ago (2013-09-26 21:01:44 UTC) #3
binji
lgtm, sorry for the delay. https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/devguide/coding/audio.rst File native_client_sdk/src/doc/devguide/coding/audio.rst (right): https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/devguide/coding/audio.rst#newcode61 native_client_sdk/src/doc/devguide/coding/audio.rst:61: <http://chromium.googlecode.com/svn/trunk/samples/audio/index.html>`_. We also include ...
7 years, 2 months ago (2013-10-02 07:00:42 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/devguide/coding/audio.rst File native_client_sdk/src/doc/devguide/coding/audio.rst (right): https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/devguide/coding/audio.rst#newcode61 native_client_sdk/src/doc/devguide/coding/audio.rst:61: <http://chromium.googlecode.com/svn/trunk/samples/audio/index.html>`_. On 2013/10/02 07:00:42, binji wrote: > We also ...
7 years, 2 months ago (2013-10-17 21:57:36 UTC) #5
binji
slgtm, thanks! https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/devguide/coding/audio.rst File native_client_sdk/src/doc/devguide/coding/audio.rst (right): https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/devguide/coding/audio.rst#newcode61 native_client_sdk/src/doc/devguide/coding/audio.rst:61: <http://chromium.googlecode.com/svn/trunk/samples/audio/index.html>`_. On 2013/10/17 21:57:36, stichnot wrote: > ...
7 years, 2 months ago (2013-10-17 21:59:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stichnot@chromium.org/24446002/15001
7 years, 2 months ago (2013-10-17 22:07:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stichnot@chromium.org/24446002/15001
7 years, 2 months ago (2013-10-18 01:20:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stichnot@chromium.org/24446002/15001
7 years, 2 months ago (2013-10-22 20:18:31 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 23:05:21 UTC) #10
Message was sent while issue was closed.
Change committed as 230244

Powered by Google App Engine
This is Rietveld 408576698