Port Pepper Audio API from the devsite.

Port Pepper Audio API from the devsite.

BUG= none
NOTRY=true 
(documentation-only change)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230244

[Jim Stichnoth, 2013-09-24 21:51:46]

I recreated the two images in Drive, and unintentionally overwrote the
preexisting images of the same names.  (That's probably the right thing to do,
but let me know if not.)

[eliben, 2013-09-25 20:01:47]

lgtm with nits

Ben: how do we know the code is still correct?

https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/dev...
File native_client_sdk/src/doc/devguide/coding/audio.rst (right):

https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/dev...
native_client_sdk/src/doc/devguide/coding/audio.rst:32: TODO(stichnot): This is
the wrong link to the examples gallery.  Are we going
Remove it for now. We can add it back later when we figure out how to port the
gallery

https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/dev...
native_client_sdk/src/doc/devguide/coding/audio.rst:250:
``RecommendSampleFrameCount()`` to obtain a *sample frame count* from the
The convention is to ged rid of the parens, just
``RecommendedSampleFrameCount``. Apply everywhere

[Jim Stichnoth, 2013-09-26 21:01:44]

PTAL.  No committing until binji signoff.

https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/dev...
File native_client_sdk/src/doc/devguide/coding/audio.rst (right):

https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/dev...
native_client_sdk/src/doc/devguide/coding/audio.rst:32: TODO(stichnot): This is
the wrong link to the examples gallery.  Are we going
On 2013/09/25 20:01:48, eliben wrote:
> Remove it for now. We can add it back later when we figure out how to port the
> gallery

Done.

https://codereview.chromium.org/24446002/diff/1/native_client_sdk/src/doc/dev...
native_client_sdk/src/doc/devguide/coding/audio.rst:250:
``RecommendSampleFrameCount()`` to obtain a *sample frame count* from the
On 2013/09/25 20:01:48, eliben wrote:
> The convention is to ged rid of the parens, just
> ``RecommendedSampleFrameCount``. Apply everywhere

Done.

[binji, 2013-10-02 07:00:42]

lgtm, sorry for the delay.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
File native_client_sdk/src/doc/devguide/coding/audio.rst (right):

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:61:
<http://chromium.googlecode.com/svn/trunk/samples/audio/index.html>`_.
We also include ogg/vorbis/openAL in the SDK now, but we don't really have an
example of it. And there are other audio libraries in naclports. Worth
referencing?

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:132: ``pp::Module`` and
``pp::Instance`` classes, as normal.
None of the other documents (aside from the tutorial) show how to set up the
instance/module, do they? I think this may be overkill.

Maybe we should remove this, or just keep the SineWaveCallback and pp::Audio,
which is different than normal.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:254:
``toolchain/platform/x86_64-nacl/include/ppapi/c/ppb_audio_config.h`` for the
this location is ``include/ppapi/c/ppb_audio_config.h`` now

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:277: * sample rate: 44,100
Hz or 48,000 Hz
There is a duplicated table above. Should we remove one copy?

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:287: bool
SineSynthInstance::Init(uint32_t argc,
This has changed slightly, but maybe it's better to keep this version because it
is clearer?
https://code.google.com/p/chromium/codesearch#chromium/src/native_client_sdk/...

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:320: .. naclcode::
This is a duplicate of the above code. Remove one?

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:376:
reinterpret_cast<SineSynthInstance*>(data);
hmm, these reinterpret_casts should really be static_casts. But they are
reinterpret_casts in the code as well. :-/

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:404: }
This code is basically the same as the example. I thought it might be too
complex, but it it's probably OK.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:452: module calls
``StartPlayback`` when the module instance is created; a more
This is no longer true, the StartPlayback/StopPlayback calls happen as a result
of JavaScript messages:
https://code.google.com/p/chromium/codesearch#chromium/src/native_client_sdk/...

[Jim Stichnoth, 2013-10-17 21:57:36]

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
File native_client_sdk/src/doc/devguide/coding/audio.rst (right):

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:61:
<http://chromium.googlecode.com/svn/trunk/samples/audio/index.html>`_.
On 2013/10/02 07:00:42, binji wrote:
> We also include ogg/vorbis/openAL in the SDK now, but we don't really have an
> example of it. And there are other audio libraries in naclports. Worth
> referencing?

I don't really have enough knowledge to add something accurate and intelligent
here, but I'll be happy to paste in some text. :)

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:132: ``pp::Module`` and
``pp::Instance`` classes, as normal.
On 2013/10/02 07:00:42, binji wrote:
> None of the other documents (aside from the tutorial) show how to set up the
> instance/module, do they? I think this may be overkill.
> 
> Maybe we should remove this, or just keep the SineWaveCallback and pp::Audio,
> which is different than normal.

I trimmed the example back a bunch.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:254:
``toolchain/platform/x86_64-nacl/include/ppapi/c/ppb_audio_config.h`` for the
On 2013/10/02 07:00:42, binji wrote:
> this location is ``include/ppapi/c/ppb_audio_config.h`` now

Done.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:277: * sample rate: 44,100
Hz or 48,000 Hz
On 2013/10/02 07:00:42, binji wrote:
> There is a duplicated table above. Should we remove one copy?

Done.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:320: .. naclcode::
On 2013/10/02 07:00:42, binji wrote:
> This is a duplicate of the above code. Remove one?

Done.

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:452: module calls
``StartPlayback`` when the module instance is created; a more
On 2013/10/02 07:00:42, binji wrote:
> This is no longer true, the StartPlayback/StopPlayback calls happen as a
result
> of JavaScript messages:
>
https://code.google.com/p/chromium/codesearch#chromium/src/native_client_sdk/...

Done.

[binji, 2013-10-17 21:59:54]

slgtm, thanks!

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
File native_client_sdk/src/doc/devguide/coding/audio.rst (right):

https://codereview.chromium.org/24446002/diff/8001/native_client_sdk/src/doc/...
native_client_sdk/src/doc/devguide/coding/audio.rst:61:
<http://chromium.googlecode.com/svn/trunk/samples/audio/index.html>`_.
On 2013/10/17 21:57:36, stichnot wrote:
> On 2013/10/02 07:00:42, binji wrote:
> > We also include ogg/vorbis/openAL in the SDK now, but we don't really have
an
> > example of it. And there are other audio libraries in naclports. Worth
> > referencing?
> 
> I don't really have enough knowledge to add something accurate and intelligent
> here, but I'll be happy to paste in some text. :)

OK, we can leave it out for now.

[commit-bot: I haz the power, 2013-10-17 22:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stichnot@chromium.org/24446002/15001

[commit-bot: I haz the power, 2013-10-18 01:20:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stichnot@chromium.org/24446002/15001

[commit-bot: I haz the power, 2013-10-22 20:18:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stichnot@chromium.org/24446002/15001

[commit-bot: I haz the power, 2013-10-22 23:05:21]

Change committed as 230244