cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/6c872fc0e1e9b381615f325e33463e16f936960c
Cr-Commit-Position: refs/heads/master@{#426969}

[danakj, 2016-10-21 23:22:19]

Description was changed from

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
BUG=606056
==========

to

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-21 23:22:25]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-10-21 23:22:39]

Description was changed from

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-21 23:23:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-21 23:23:05]

danakj@chromium.org changed reviewers:
+ jamescook@chromium.org

[danakj, 2016-10-21 23:23:25]

danakj@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[danakj, 2016-10-21 23:23:49]

piman: please review
jamescook: ash owners
khushalsagar: blimp owners

[Khushal, 2016-10-21 23:24:41]

lgtm

[James Cook, 2016-10-21 23:31:40]

ash lgtm

[danakj, 2016-10-21 23:32:44]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2016-10-21 23:32:44]

+sky for ui/views/ and WebKit/ (top level owner) who I'll TBR on those trivial
bits.

[oshima, 2016-10-21 23:33:24]

oshima@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2016-10-21 23:33:25]

drive-by nit:

https://codereview.chromium.org/2444563002/diff/1/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

https://codereview.chromium.org/2444563002/diff/1/ash/wm/window_animations.cc...
ash/wm/window_animations.cc:278: void OnCompositingShuttingDown(ui::Compositor*
compositor) override {}
nit: looks like we can remove CompositorObserver from this class?

[danakj, 2016-10-21 23:36:52]

https://codereview.chromium.org/2444563002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/2444563002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:815: ScheduleComposite();
This would possibly prevent context recovery because we have to composite to get
a context, but layout tests don't lose context and I NOTREACHED() that this is
the case and bots will inform me otherwise.

Oh, and ScheduleComposite does nothing unless
GetCompositorImplThreadTaskRunner() is true which it isnt in single thread
anyway so I think this is all no-ops.

https://codereview.chromium.org/2444563002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:822: DidFlushPaint();
This looks scary but RWC calls DidCompleteSwapBuffers right before calling
OnSwapBuffersAborted, and it does the same thing, so we were doing this twice.

[danakj, 2016-10-21 23:37:42]

https://codereview.chromium.org/2444563002/diff/1/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

https://codereview.chromium.org/2444563002/diff/1/ash/wm/window_animations.cc...
ash/wm/window_animations.cc:278: void OnCompositingShuttingDown(ui::Compositor*
compositor) override {}
On 2016/10/21 23:33:25, oshima wrote:
> nit: looks like we can remove CompositorObserver from this class?

Agreed! Done.

[danakj, 2016-10-21 23:38:06]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 23:38:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-10-21 23:44:22]

https://codereview.chromium.org/2444563002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/compositor_impl_android.cc (left):

https://codereview.chromium.org/2444563002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/compositor_impl_android.cc:795:
host_->SetNeedsCommit();
What makes it ok to remove? Is there another mechanism (BeginFrame?) to do this
instead?

https://codereview.chromium.org/2444563002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/2444563002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:815: ScheduleComposite();
On 2016/10/21 23:36:52, danakj wrote:
> This would possibly prevent context recovery because we have to composite to
get
> a context, but layout tests don't lose context and I NOTREACHED() that this is
> the case and bots will inform me otherwise.
> 
> Oh, and ScheduleComposite does nothing unless
> GetCompositorImplThreadTaskRunner() is true which it isnt in single thread
> anyway so I think this is all no-ops.

I think most uses of ScheduleComposite are wrong (either redundant or not
sufficient if it was needed), so I'm pretty ok with that

[danakj, 2016-10-21 23:46:20]

https://codereview.chromium.org/2444563002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/compositor_impl_android.cc (left):

https://codereview.chromium.org/2444563002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/compositor_impl_android.cc:795:
host_->SetNeedsCommit();
On 2016/10/21 23:44:22, piman wrote:
> What makes it ok to remove? Is there another mechanism (BeginFrame?) to do
this
> instead?

Oh right this one. SingleThreadProxy::DidLoseCompositorFrameSinkOnImplThread()
used to call this. It also calls layer_tree_host_->DidLoseCompositorFrameSink()
which does SetNeedsCommit() unconditionally. So this was conditionally calling
it a 2nd time.

https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_in_process.cc?r...

[piman, 2016-10-21 23:47:17]

lgtm

[danakj, 2016-10-21 23:47:51]

Description was changed from

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-10-21 23:48:01]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-10-21 23:48:04]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-10-21 23:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2444563002/#ps20001
(title: "swapsinglethread: remove-compositor-observer")

[commit-bot: I haz the power, 2016-10-21 23:48:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-21 23:50:09]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-10-21 23:51:30]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-10-21 23:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, piman@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2444563002/#ps40001
(title: "swapsinglethread: fix-name-in-browsertest")

[commit-bot: I haz the power, 2016-10-21 23:52:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 04:30:15]

Description was changed from

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-22 04:30:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-22 04:34:46]

Description was changed from

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

And clean up uses of this interface.

DidAbortSwapBuffers becomes DidLoseCompositorFrameSink. Android uses
this to tell the browser that it has no pending frames and can make
a new frame. Ash was using this to end crossfade maximize animations.
I've removed this and dropped "aborting" compositing from the Compositor
observer.

DidPostSwapBuffers becomes DidSubmitCompositorFrame which represents
itself better. RenderWidgetCompositor was telling RenderWidget about
this just to make a trace event, so deleted that.

DidReceiveCompositorFrameAck is duplicated in LayerTreeHostClient
and was not actually called on this interface anymore, so just deleted
it.

R=piman@chromium.org
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/6c872fc0e1e9b381615f325e33463e16f936960c
Cr-Commit-Position: refs/heads/master@{#426969}
==========

[commit-bot: I haz the power, 2016-10-22 04:34:47]

Patchset 3 (id:??) landed as
https://crrev.com/6c872fc0e1e9b381615f325e33463e16f936960c
Cr-Commit-Position: refs/heads/master@{#426969}