|
|
Created:
4 years, 2 months ago by please use gerrit instead Modified:
4 years, 1 month ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, rouslan+payments_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOverwrite the HeapVector of ShippingOptions for more clear code.
BUG=600808
Committed: https://crrev.com/e177f658f2b6ab19fac1885586f2b25bf9975aa8
Cr-Commit-Position: refs/heads/master@{#427181}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 22 (12 generated)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
rouslan@chromium.org changed reviewers: + haraken@chromium.org
haraken, ptal.
LGTM
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by rouslan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2444493002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Overwrite the HeapVector of ShippingOptions for more clear code. BUG=600808 ========== to ========== Overwrite the HeapVector of ShippingOptions for more clear code. BUG=600808 Committed: https://crrev.com/e177f658f2b6ab19fac1885586f2b25bf9975aa8 Cr-Commit-Position: refs/heads/master@{#427181} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e177f658f2b6ab19fac1885586f2b25bf9975aa8 Cr-Commit-Position: refs/heads/master@{#427181}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2456783004/ by rouslan@chromium.org. The reason for reverting is: Breaks CFI. https://bugs.chromium.org/p/chromium/issues/detail?id=659885 . |