Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2444493002: Overwrite the HeapVector of ShippingOptions for more clear code. (Closed)

Created:
4 years, 2 months ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, rouslan+payments_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Overwrite the HeapVector of ShippingOptions for more clear code. BUG=600808 Committed: https://crrev.com/e177f658f2b6ab19fac1885586f2b25bf9975aa8 Cr-Commit-Position: refs/heads/master@{#427181}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -53 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 8 chunks +31 lines, -53 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
please use gerrit instead
haraken, ptal.
4 years, 1 month ago (2016-10-24 13:47:33 UTC) #6
haraken
LGTM
4 years, 1 month ago (2016-10-24 13:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444493002/1
4 years, 1 month ago (2016-10-24 13:49:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301351)
4 years, 1 month ago (2016-10-24 15:46:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444493002/1
4 years, 1 month ago (2016-10-24 17:07:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287888)
4 years, 1 month ago (2016-10-24 17:30:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444493002/20001
4 years, 1 month ago (2016-10-24 20:05:09 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 23:49:30 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e177f658f2b6ab19fac1885586f2b25bf9975aa8 Cr-Commit-Position: refs/heads/master@{#427181}
4 years, 1 month ago (2016-10-24 23:51:48 UTC) #21
please use gerrit instead
4 years, 1 month ago (2016-10-27 11:45:00 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2456783004/ by rouslan@chromium.org.

The reason for reverting is: Breaks CFI.
https://bugs.chromium.org/p/chromium/issues/detail?id=659885
.

Powered by Google App Engine
This is Rietveld 408576698