Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7956)

Unified Diff: chrome/browser/ui/webui/settings/people_handler.cc

Issue 2444443002: cros: Allow pin keyboard to keep focus without popping up the pin keyboard. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler.cc
diff --git a/chrome/browser/ui/webui/settings/people_handler.cc b/chrome/browser/ui/webui/settings/people_handler.cc
index 927294382c272b68b51569c34594e73bfdf58f4d..82ea780e937a19f622fcf3ac723faffaff31cddb 100644
--- a/chrome/browser/ui/webui/settings/people_handler.cc
+++ b/chrome/browser/ui/webui/settings/people_handler.cc
@@ -59,6 +59,7 @@
#if defined(OS_CHROMEOS)
#include "components/signin/core/browser/signin_manager_base.h"
+#include "ui/keyboard/keyboard_util.h"
#else
#include "components/signin/core/browser/signin_manager.h"
#endif
@@ -216,6 +217,10 @@ void PeopleHandler::RegisterMessages() {
"SyncSetupDoSignOutOnAuthError",
base::Bind(&PeopleHandler::HandleDoSignOutOnAuthError,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback(
+ "SetForceDisableVirtualKeyboard",
+ base::Bind(&PeopleHandler::HandleSetForceDisableVirtualKeyboard,
+ base::Unretained(this)));
#else
web_ui()->RegisterMessageCallback(
"SyncSetupStopSyncing",
@@ -515,6 +520,13 @@ void PeopleHandler::HandleDoSignOutOnAuthError(const base::ListValue* args) {
DVLOG(1) << "Signing out the user to fix a sync error.";
chrome::AttemptUserExit();
}
+
+void PeopleHandler::HandleSetForceDisableVirtualKeyboard(
+ const base::ListValue* args) {
+ bool disable_keyboard = false;
+ args->GetBoolean(0, &disable_keyboard);
+ keyboard::SetForceDisableVirtualKeyboardForWebUi(disable_keyboard);
xiyuan 2016/11/09 18:06:32 Do we need to make sure this is reverted in People
sammiequon 2016/11/10 21:06:01 Decided to remove blocking keyboard in settings, s
+}
#endif
#if !defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698