Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.js

Issue 2444443002: cros: Allow pin keyboard to keep focus without popping up the pin keyboard. (Closed)
Patch Set: Fixed patch set 5 errors. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.js
diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
index 72b68c829117e51f0c2c6f3cd11895926a6be534..cdb8a05d6c7ac373a87ad3ca5fe77df1c924eb56 100644
--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
@@ -78,6 +78,11 @@ Polymer({
open: function() {
this.$.dialog.showModal();
this.$.pinKeyboard.focus();
+
+ // Each tap of the PIN keyboard button transfers focus to the PIN input,
+ // which will keep opening the virtual keyboard. Disable the virtual
+ // keyboard while this dialog is present.
+ chrome.send('SetForceDisableVirtualKeyboard', [true]);
},
close: function() {
@@ -85,6 +90,9 @@ Polymer({
this.$.dialog.close();
this.resetState_();
+
+ // Renable the virtual keyboard.
+ chrome.send('SetForceDisableVirtualKeyboard', [false]);
},
/**

Powered by Google App Engine
This is Rietveld 408576698