ui/keyboard/scoped_keyboard_disabler.cc - Issue 2444443002: cros: Allow pin keyboard to keep focus without popping up the pin keyboard.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/keyboard/scoped_keyboard_disabler.cc

Issue 2444443002: cros: Allow pin keyboard to keep focus without popping up the pin keyboard. (Closed)

Patch Set: Fixed patch set 8 errors. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/keyboard/scoped_keyboard_disabler.h"

	6

	7 #include "ui/keyboard/keyboard_util.h"

	8

	9 namespace keyboard {

	10

	11 ScopedKeyboardDisabler::ScopedKeyboardDisabler() {}

	12

	13 ScopedKeyboardDisabler::~ScopedKeyboardDisabler() {

	14 SetForceDisableVirtualKeyboardForWebUi(false);
	xiyuan 2016/11/10 21:48:35 Think a scoped object would cache original value i Think a scoped object would cache original value in ctor and restore it here. sammiequon 2016/11/10 22:36:56 Done. Show quoted text On 2016/11/10 21:48:35, xiyuan wrote: > Think a scoped object would cache original value in ctor and restore it here. Done.
	15 }

	16

	17 void ScopedKeyboardDisabler::SetForceDisableVirtualKeyboard(bool disable) {

	18 SetForceDisableVirtualKeyboardForWebUi(disable);

	19 }

	20

	21 } // namespace keyboard

OLD	NEW