Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2444423002: Merge to 2883 "[DevTools] Move sanitize url to devtools_ui.cc." (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Merge to 2883 "[DevTools] Move sanitize url to devtools_ui.cc." > [DevTools] Move sanitize url to devtools_ui.cc. > > Compatibility script is not reliable enough. > > BUG=653134 > > Review-Url: https://codereview.chromium.org/2403633002 > Cr-Commit-Position: refs/heads/master@{#425814} (cherry picked from commit f865c2dfddb1d95af3a2467587c62566e3f7dfe4) TBR=pfeldman Committed: https://chromium.googlesource.com/chromium/src/+/528c2bce2ece070826a84392d66169ffe33afdcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -52 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 4 chunks +137 lines, -2 lines 0 comments Download
A chrome/browser/ui/webui/devtools_ui_unittest.cc View 1 chunk +102 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/devtools/devtools_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 4 chunks +2 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgozman
4 years, 1 month ago (2016-10-25 18:56:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
528c2bce2ece070826a84392d66169ffe33afdcd.

Powered by Google App Engine
This is Rietveld 408576698