Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: components/session_manager/core/session_manager.h

Issue 2444383008: session_manager: Create ChromeSessionManager early (Closed)
Patch Set: for #4 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/session_manager/core/session_manager.h
diff --git a/components/session_manager/core/session_manager.h b/components/session_manager/core/session_manager.h
index e7550e1032e5f64c4970139f808accb673ddbd8e..53623178136041a46941716bd4f08a3a9b935a70 100644
--- a/components/session_manager/core/session_manager.h
+++ b/components/session_manager/core/session_manager.h
@@ -5,16 +5,12 @@
#ifndef COMPONENTS_SESSION_MANAGER_CORE_SESSION_MANAGER_H_
#define COMPONENTS_SESSION_MANAGER_CORE_SESSION_MANAGER_H_
-#include <memory>
-
#include "base/macros.h"
#include "components/session_manager/session_manager_export.h"
#include "components/session_manager/session_manager_types.h"
namespace session_manager {
-class SessionManagerDelegate;
-
class SESSION_EXPORT SessionManager {
public:
SessionManager();
@@ -40,14 +36,7 @@ class SESSION_EXPORT SessionManager {
// before the session has been started.
virtual void SessionStarted();
- // Let session delegate executed on its plan of actions depending on the
- // current session type / state.
- void Start();
-
protected:
- // Initializes SessionManager with delegate.
- void Initialize(SessionManagerDelegate* delegate);
-
// Sets SessionManager instance.
static void SetInstance(SessionManager* session_manager);
@@ -60,7 +49,6 @@ class SESSION_EXPORT SessionManager {
static SessionManager* instance;
SessionState session_state_ = SessionState::UNKNOWN;
- std::unique_ptr<SessionManagerDelegate> delegate_;
// True if SessionStarted() has been called.
bool session_started_ = false;
@@ -68,24 +56,6 @@ class SESSION_EXPORT SessionManager {
DISALLOW_COPY_AND_ASSIGN(SessionManager);
};
-class SESSION_EXPORT SessionManagerDelegate {
- public:
- SessionManagerDelegate();
- virtual ~SessionManagerDelegate();
-
- virtual void SetSessionManager(
- session_manager::SessionManager* session_manager);
-
- // Executes specific actions defined by this delegate.
- virtual void Start() = 0;
-
- protected:
- session_manager::SessionManager* session_manager_ = nullptr;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(SessionManagerDelegate);
-};
-
} // namespace session_manager
#endif // COMPONENTS_SESSION_MANAGER_CORE_SESSION_MANAGER_H_
« no previous file with comments | « chrome/browser/chromeos/login/ui/user_adding_screen.cc ('k') | components/session_manager/core/session_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698