Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4557)

Unified Diff: chrome/browser/chromeos/login/session/chrome_session_manager.h

Issue 2444383008: session_manager: Create ChromeSessionManager early (Closed)
Patch Set: fix compile, StubLoginSessionInitializer -> StubSessionInitializer Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/session/chrome_session_manager.h
diff --git a/chrome/browser/chromeos/login/session/chrome_session_manager.h b/chrome/browser/chromeos/login/session/chrome_session_manager.h
index 2a46d6c042dbcee5ac1506941535ed4b44bdcb15..ee75d633b5dd4c3c6898cec8959fdc70abd63d86 100644
--- a/chrome/browser/chromeos/login/session/chrome_session_manager.h
+++ b/chrome/browser/chromeos/login/session/chrome_session_manager.h
@@ -18,19 +18,19 @@ namespace chromeos {
class ChromeSessionManager : public session_manager::SessionManager {
public:
- static std::unique_ptr<session_manager::SessionManager> CreateSessionManager(
- const base::CommandLine& parsed_command_line,
- Profile* profile,
- bool is_running_test);
-
- private:
- explicit ChromeSessionManager(
- session_manager::SessionManagerDelegate* delegate);
+ ChromeSessionManager();
~ChromeSessionManager() override;
+ // Initialize and start user sessions as well as responsible on launching
achuithb 2016/10/27 19:12:45 The grammar here isn't quite right. I don't quite
xiyuan 2016/10/27 21:10:43 Copy-n-pasted from existing BrowserProcessPlatform
+ // pre-session UI like out-of-box or login.
+ void Initialize(const base::CommandLine& parsed_command_line,
+ Profile* profile,
+ bool is_running_test);
+
// session_manager::SessionManager:
void SessionStarted() override;
+ private:
DISALLOW_COPY_AND_ASSIGN(ChromeSessionManager);
};

Powered by Google App Engine
This is Rietveld 408576698