Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc

Issue 2444383007: Trigger Dangerous indicator for unsafe subresources (Closed)
Patch Set: protip: #include the .h, not the .cc Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
index 19032113412e117a9f2506360a6fcd63ce93c759..f87bffe308e1aa33e951e04912dbbe1199571531 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
@@ -1232,7 +1232,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTestWithPasswordCcSwitch,
ASSERT_NO_FATAL_FAILURE(CheckForOneHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Two subsequent triggers of VisibleSSLStateChanged -- one on the
+ // Two subsequent triggers of VisibleSecurityStateChanged -- one on the
// same navigation and one on another navigation -- should only result
// in one additional console message.
contents->OnCreditCardInputShownOnHttp();
@@ -1305,7 +1305,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, ConsoleMessage) {
ASSERT_NO_FATAL_FAILURE(CheckForOneFutureHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Two subsequent triggers of VisibleSSLStateChanged -- one on the
+ // Two subsequent triggers of VisibleSecurityStateChanged -- one on the
// same navigation and one on another navigation -- should only result
// in one additional console message.
contents->OnCreditCardInputShownOnHttp();
@@ -1376,7 +1376,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTestWithPasswordCcSwitch,
ASSERT_NO_FATAL_FAILURE(CheckForOneHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Navigate the subframe and trigger VisibleSSLStateChanged
+ // Navigate the subframe and trigger VisibleSecurityStateChanged
// again. While the security level is still HTTP_SHOW_WARNING, an
// additional console message should not be logged because there was
// already a console message logged for the current main-frame
@@ -1460,7 +1460,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTestWithPasswordCcSwitch,
ASSERT_NO_FATAL_FAILURE(CheckForOneHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Navigate with pushState and trigger VisibleSSLStateChanged
+ // Navigate with pushState and trigger VisibleSecurityStateChanged
// again. While the security level is still HTTP_SHOW_WARNING, an
// additional console message should not be logged because there was
// already a console message logged for the current main-frame

Powered by Google App Engine
This is Rietveld 408576698