Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3463)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Issue 2444373003: Adding/renaming a folder in the bookmark manager should not hide the icon. (Closed)
Patch Set: Fix closure compile Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/bookmark_manager/css/bmm.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
index 7582698b0f1c1a5e11cf8bdba7afa961cb1262e3..2612c5073c9fb5f92c7e81c719559b6dc6ded69a 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
@@ -479,8 +479,8 @@ cr.define('bmm', function() {
var title = this.bookmarkNode.title;
var isFolder = bmm.isFolder(this.bookmarkNode);
var listItem = this;
- var labelEl = this.firstChild;
- var urlEl = labelEl.nextSibling;
+ var labelEl = queryRequiredElement('.label-text', this);
Dan Beam 2016/10/27 03:56:17 labelTextEl?
Peter Kasting 2016/10/27 06:00:26 Done.
+ var urlEl = queryRequiredElement('.url', this);
var labelInput, urlInput;
// Handles enter and escape which trigger reset and commit respectively.
« no previous file with comments | « chrome/browser/resources/bookmark_manager/css/bmm.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698