Adding/renaming a folder in the bookmark manager should not hide the icon.

chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
index 7582698b0f1c1a5e11cf8bdba7afa961cb1262e3..b8dda0ecb8052ed23eac2f70b2c3e0e2af483b6e 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
@@ -479,8 +479,8 @@ cr.define('bmm', function() {
       var title = this.bookmarkNode.title;
       var isFolder = bmm.isFolder(this.bookmarkNode);
       var listItem = this;
-      var labelEl = this.firstChild;
-      var urlEl = labelEl.nextSibling;
+      var labelEl = this.querySelector('.label-text');
+      var urlEl = this.querySelector('.url');

[Peter Kasting, 2016/10/26 01:49:57]

I could have used a bunch of .firstChild.nextSibling and similar statements, but
this seemed less fragile to future changes.

[Peter Kasting, 2016/10/26 02:56:30]

...however, now Closure compiler complains that labelEl is (Element|null) at
line 556, and Node is required.

Do I just need to put in some sort of explicit (pointless) null-check here?

[Dan Beam, 2016/10/26 03:06:21]

assert(), queryRequiredElement() or /** @type {!Element} */(...)

[Peter Kasting, 2016/10/26 03:33:59]

Thanks; used queryRequiredElement() since that seemed the most elegant.

       var labelInput, urlInput;
 
       // Handles enter and escape which trigger reset and commit respectively.