Adding/renaming a folder in the bookmark manager should not hide the icon.

chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(arv): Now that this is driven by a data model, implement a data model
 //            that handles the loading and the events from the bookmark backend.
 
 /**
  * @typedef {{childIds: Array<string>}}
  *
@@ skipping 461 matching lines @@
     },
     set editing(editing) {
       var oldEditing = this.editing;
       if (oldEditing == editing)
         return;
 
       var url = this.bookmarkNode.url;
       var title = this.bookmarkNode.title;
       var isFolder = bmm.isFolder(this.bookmarkNode);
       var listItem = this;
-      var labelEl = this.firstChild;
-      var urlEl = labelEl.nextSibling;
+      var labelEl = this.querySelector('.label-text');
+      var urlEl = this.querySelector('.url');

[Peter Kasting, 2016/10/26 01:49:57]

I could have used a bunch of .firstChild.nextSibling and similar statements, but
this seemed less fragile to future changes.

[Peter Kasting, 2016/10/26 02:56:30]

...however, now Closure compiler complains that labelEl is (Element|null) at
line 556, and Node is required.

Do I just need to put in some sort of explicit (pointless) null-check here?

[Dan Beam, 2016/10/26 03:06:21]

assert(), queryRequiredElement() or /** @type {!Element} */(...)

[Peter Kasting, 2016/10/26 03:33:59]

Thanks; used queryRequiredElement() since that seemed the most elegant.

       var labelInput, urlInput;
 
       // Handles enter and escape which trigger reset and commit respectively.
       function handleKeydown(e) {
         // Make sure that the tree does not handle the key.
         e.stopPropagation();
 
         // Calling list.focus blurs the input which will stop editing the list
         // item.
         switch (e.key) {
@@ skipping 146 matching lines @@
         }
       }
     }
   };
 
   return {
     BookmarkList: BookmarkList,
     list: /** @type {Element} */(null),  // Set when decorated.
   };
 });