Handle the case of Stream.take(0) better.

tests/lib/async/stream_take_test.dart

Index: tests/lib/async/stream_take_test.dart
diff --git a/tests/lib/async/stream_take_test.dart b/tests/lib/async/stream_take_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..b094eed137cd9b297953f2dff9c29f90d023e434
--- /dev/null
+++ b/tests/lib/async/stream_take_test.dart
@@ -0,0 +1,63 @@
+// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:async';
+import "package:expect/expect.dart";
+import "package:async_helper/async_helper.dart";
+
+class A { const A(); }
+class B extends A { const B(); }
+
+/// Stream which emits an error if it's not cancelled at the correct time.
+///
+/// Must be cancelled after at least [minEvents] and at most [maxEvents] events.

[floitsch, 2016/10/31 17:09:31]

there is no 'minEvents'.

+Stream makeStream(int maxEvents) {
+  var c;
+  int event = 0;
+  bool cancelled = false;

[floitsch, 2016/10/31 17:09:31]

generally we use "canceled".

+  c = new StreamController(onListen: () {
+    new Timer.periodic(const Duration(milliseconds: 10), (t) {
+      if (cancelled) {
+        t.cancel();
+        return;
+      }
+      if (event == maxEvents) {
+        c.addError("NOT CANCELLED IN TIME: $maxEvents");

[floitsch, 2016/10/31 17:09:31]

ditto.

+        c.close();
+        t.cancel();
+      } else {
+        c.add(event++);
+      }
+    });
+  }, onCancel: () {
+    cancelled = true;
+  });
+  return c.stream;
+}
+
+main() {
+  asyncStart();
+  tests().then((_) { asyncEnd(); });
+}
+
+tests() async {
+  await expectThrowsAsync(makeStream(4).take(5).toList(), "5/4");
+  await expectThrowsAsync(makeStream(0).take(1).toList(), "1/0");
+
+  Expect.listEquals([0, 1, 2, 3, 4], await makeStream(5).take(5).toList());
+
+  Expect.listEquals([0, 1, 2, 3], await makeStream(5).take(4).toList());
+
+  Expect.listEquals([0], await makeStream(5).take(1).toList());
+
+  Expect.listEquals([], await makeStream(5).take(0).toList());
+
+  Expect.listEquals([], await makeStream(0).take(0).toList());
+}
+
+Future expectThrowsAsync(Future computation, String name) {
+  return computation.then((_) {
+    Expect.fail("$name: Did not throw");
+  }, onError: (e, s){});
+}