Handle the case of Stream.take(0) better.

Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
Committed: https://github.com/dart-lang/sdk/commit/9ebef9af7c7086a4e0f935b3ebd29aa4e990da91
Committed: https://github.com/dart-lang/sdk/commit/7bb7f5e6bb5c75471bb3f4f46a3eea0e1e3d1c36

[Lasse Reichstein Nielsen, 2016-10-26 07:24:28]

lrn@google.com changed reviewers:
+ floitsch@google.com, kmillikin@google.com

[floitsch, 2016-10-31 17:09:31]

LGTM.
I wonder if the `take` should wait for the `cancel` to finish, so that it can
report the error. I wouldn't know where and how, though.

https://codereview.chromium.org/2444363004/diff/1/tests/lib/async/stream_take...
File tests/lib/async/stream_take_test.dart (right):

https://codereview.chromium.org/2444363004/diff/1/tests/lib/async/stream_take...
tests/lib/async/stream_take_test.dart:14: /// Must be cancelled after at least
[minEvents] and at most [maxEvents] events.
there is no 'minEvents'.

https://codereview.chromium.org/2444363004/diff/1/tests/lib/async/stream_take...
tests/lib/async/stream_take_test.dart:18: bool cancelled = false;
generally we use "canceled".

https://codereview.chromium.org/2444363004/diff/1/tests/lib/async/stream_take...
tests/lib/async/stream_take_test.dart:26: c.addError("NOT CANCELLED IN TIME:
$maxEvents");
ditto.

[Lasse Reichstein Nielsen, 2016-11-04 13:55:03]

Description was changed from

==========
Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.
==========

to

==========
Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
==========

[Lasse Reichstein Nielsen, 2016-11-04 13:55:05]

Committed patchset #4 (id:60001) manually as
8cead4090cc0b1184a2ad552003ac38cae1e2c77 (presubmit successful).

[Lasse Reichstein Nielsen, 2016-11-04 14:55:09]

Description was changed from

==========
Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
==========

to

==========
Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
Committed:
https://github.com/dart-lang/sdk/commit/9ebef9af7c7086a4e0f935b3ebd29aa4e990da91
==========

[Lasse Reichstein Nielsen, 2016-11-04 14:55:10]

Committed patchset #4 (id:60001) manually as
9ebef9af7c7086a4e0f935b3ebd29aa4e990da91 (presubmit successful).

[Lasse Reichstein Nielsen, 2016-11-07 10:48:51]

Description was changed from

==========
Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
Committed:
https://github.com/dart-lang/sdk/commit/9ebef9af7c7086a4e0f935b3ebd29aa4e990da91
==========

to

==========
Handle the case of Stream.take(0) better.

The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
Committed:
https://github.com/dart-lang/sdk/commit/9ebef9af7c7086a4e0f935b3ebd29aa4e990da91
Committed:
https://github.com/dart-lang/sdk/commit/7bb7f5e6bb5c75471bb3f4f46a3eea0e1e3d1c36
==========

[Lasse Reichstein Nielsen, 2016-11-07 10:48:55]

Committed patchset #6 (id:100001) manually as
7bb7f5e6bb5c75471bb3f4f46a3eea0e1e3d1c36 (presubmit successful).