Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2444363003: Remove uses of ChannelHandle for service processes. (Closed)

Created:
4 years, 1 month ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of ChannelHandle for service processes. ChannelHandle will soon only support mojo handles. In preparation for this, this CL changes service process uses of ChannelHandle that relied on the storage of pipe/socket names or file descriptors to use mojo embedder types appropriate for each use. BUG=659448 Committed: https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573 Cr-Commit-Position: refs/heads/master@{#428906}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/service_process_util.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/service/service_ipc_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_ipc_server_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_process.cc View 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 45 (38 generated)
Sam McNally
+thestig for //chrome +rockot for DEPS changes
4 years, 1 month ago (2016-10-26 07:31:29 UTC) #31
Sam McNally
On 2016/10/26 07:31:29, Sam McNally wrote: > +thestig for //chrome > > +rockot for DEPS ...
4 years, 1 month ago (2016-10-31 22:30:58 UTC) #34
Ken Rockot(use gerrit already)
Sorry, lost track of this. LGTM
4 years, 1 month ago (2016-10-31 22:44:54 UTC) #35
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-31 22:58:33 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444363003/80001
4 years, 1 month ago (2016-11-01 01:32:55 UTC) #42
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 1 month ago (2016-11-01 01:37:41 UTC) #43
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 01:39:31 UTC) #45
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573
Cr-Commit-Position: refs/heads/master@{#428906}

Powered by Google App Engine
This is Rietveld 408576698