third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp - Issue 2444363002: binding: Replaces DictionaryHelper::get(ScriptValue) with get(Nullable<T>).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

Issue 2444363002: binding: Replaces DictionaryHelper::get(ScriptValue) with get(Nullable<T>). (Closed)

Patch Set: Applied git-cl-format. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h ('k') | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

index caabf543ea5a321424e8f0063a65ef75a6eb4bbd..8ef90f614f83e10ee9adb02487824fc6924b4e68 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp

@@ -129,18 +129,6 @@ CORE_EXPORT bool DictionaryHelper::get(const Dictionary& dictionary,

return getStringType(dictionary, key, value);

}

-template <>

-bool DictionaryHelper::get(const Dictionary& dictionary,

- const StringView& key,

- ScriptValue& value) {

- v8::Local<v8::Value> v8Value;

- if (!dictionary.get(key, v8Value))

- return false;

- value = ScriptValue(ScriptState::current(dictionary.isolate()), v8Value);

- return true;

template <typename NumericType>

bool getNumericType(const Dictionary& dictionary,

const StringView& key,