Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.h

Issue 2444363002: binding: Replaces DictionaryHelper::get(ScriptValue) with get(Nullable<T>). (Closed)
Patch Set: Applied git-cl-format. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 T& value) { 121 T& value) {
122 v8::Local<v8::Value> v8Value; 122 v8::Local<v8::Value> v8Value;
123 if (!dictionary.get(key, v8Value) || isUndefinedOrNull(v8Value)) 123 if (!dictionary.get(key, v8Value) || isUndefinedOrNull(v8Value))
124 return false; 124 return false;
125 return DictionaryHelper::get(dictionary, key, value); 125 return DictionaryHelper::get(dictionary, key, value);
126 } 126 }
127 template <template <typename> class PointerType, typename T> 127 template <template <typename> class PointerType, typename T>
128 static bool get(const Dictionary&, 128 static bool get(const Dictionary&,
129 const StringView& key, 129 const StringView& key,
130 PointerType<T>& value); 130 PointerType<T>& value);
131 template <typename T>
132 static bool get(const Dictionary&, const StringView& key, Nullable<T>& value);
131 }; 133 };
132 134
133 } // namespace blink 135 } // namespace blink
134 136
135 #endif // Dictionary_h 137 #endif // Dictionary_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698