Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/ic/ic.cc

Issue 2444353002: [stubs] Port KeyedStoreIC_Megamorphic stub to Turbofan (Closed)
Patch Set: polishing Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/code-stub-assembler.cc ('K') | « src/code-stub-assembler.cc ('k') | src/ic/keyed-store-generic.h » ('j') | src/ic/keyed-store-generic.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index 59b1a652a2fae50264d37b9c02db9a2e58192b58..24e29884ef1fdbcc7ec1b15af537ee636301d993 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -833,6 +833,7 @@ void IC::PatchCache(Handle<Name> name, Handle<Object> handler) {
Handle<Code> KeyedStoreIC::ChooseMegamorphicStub(Isolate* isolate,
ExtraICState extra_state) {
+ DCHECK(!FLAG_tf_store_ic_stub);
LanguageMode mode = StoreICState::GetLanguageMode(extra_state);
return is_strict(mode)
? isolate->builtins()->KeyedStoreIC_Megamorphic_Strict()
@@ -1671,7 +1672,9 @@ MaybeHandle<Object> KeyedLoadIC::Load(Handle<Object> object,
if ((object->IsJSObject() && key->IsSmi()) ||
(object->IsString() && key->IsNumber())) {
UpdateLoadElement(Handle<HeapObject>::cast(object));
- TRACE_IC("LoadIC", key);
+ if (is_vector_set()) {
Jakob Kummerow 2016/11/04 18:58:26 Drive-by fix.
+ TRACE_IC("LoadIC", key);
+ }
}
}
« src/code-stub-assembler.cc ('K') | « src/code-stub-assembler.cc ('k') | src/ic/keyed-store-generic.h » ('j') | src/ic/keyed-store-generic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698