third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp - Issue 2444323002: Throw InvalidAccessError for expired RTCCertificate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2444323002: Throw InvalidAccessError for expired RTCCertificate (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

index 97f306f93af8fedf1e899756a8aba557f7242bf7..6864379a1a07ace4549517c0c16dcab00221a8cc 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

@@ -439,9 +439,7 @@ RTCPeerConnection* RTCPeerConnection::create(

configuration.certificates) {

DOMTimeStamp expires = certificate->expires();

if (expires <= now) {

- // TODO(hbos): Per https://w3c.github.io/webrtc-pc/#operation this

- // should throw InvalidAccessError, not InvalidStateError.

- exceptionState.throwDOMException(InvalidStateError,

+ exceptionState.throwDOMException(InvalidAccessError,

"Expired certificate(s).");

return 0;

}