Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2444253002: Change accept state of PermissionRequestManager from grouped infobar (Closed)

Created:
4 years, 1 month ago by lshang
Modified:
4 years, 1 month ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change accept state of PermissionRequestManager from grouped infobar In GroupedPermissionInfobars, there is one toggle for each permission type, indicating if user wants to allow/block this type (e.g. geolocation and notification requests are grouped in a single permission prompt, user wants to allow location but block notification). This CL adds ToggleAccept() to PermissionPromptAndroid, so that accept_states_[] in PermissionRequestManager get updated when buttons on infobar get clicked, and each permission type get allowed/blocked correctly. BUG=606138 Committed: https://crrev.com/e8eaccd054223465b7eb83989b161b9f5574387b Cr-Commit-Position: refs/heads/master@{#429486}

Patch Set 1 #

Patch Set 2 : remove unused stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/permissions/permission_prompt_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_prompt_android.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
lshang
Raymes, PTAL thanks! This CL hook up ToggleAccept() of infobar and PermissionRequestManager, so that different ...
4 years, 1 month ago (2016-11-02 02:40:53 UTC) #5
raymes
lgtm
4 years, 1 month ago (2016-11-02 07:37:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444253002/40001
4 years, 1 month ago (2016-11-02 23:25:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-03 00:48:13 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 00:52:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8eaccd054223465b7eb83989b161b9f5574387b
Cr-Commit-Position: refs/heads/master@{#429486}

Powered by Google App Engine
This is Rietveld 408576698