Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js
diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js
index 8ebc34ec03b49d07162a8ffa9ca7d49446e0c608..3efb6782c3fc17c002ee9b2b8be0caf14137736b 100644
--- a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js
+++ b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js
@@ -520,13 +520,13 @@ InspectorTest.checkArrayIsSorted = function(contents, sortType, sortOrder)
InspectorTest.clickColumn = function(column, callback)
{
callback = InspectorTest.safeWrap(callback);
- var cell = this._currentGrid()._headerTableHeaders[column.identifier];
+ var cell = this._currentGrid()._headerTableHeaders[column.id];
var event = { target: { enclosingNodeOrSelfWithNodeName: function() { return cell; } } };
function sortingComplete()
{
InspectorTest._currentGrid().removeEventListener(WebInspector.HeapSnapshotSortableDataGrid.Events.SortingComplete, sortingComplete, this);
- InspectorTest.assertEquals(column.identifier, this._currentGrid().sortColumnIdentifier(), "unexpected sorting");
+ InspectorTest.assertEquals(column.id, this._currentGrid().sortColumnId(), "unexpected sorting");
column.sort = this._currentGrid().sortOrder();
function callCallback()
{

Powered by Google App Engine
This is Rietveld 408576698