third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js - Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)

Patch Set: changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js ('K') | « third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

index 9b988ce2fc2fb4be2740e8d49cd1457ed3291754..3a4865e374d25d3f4ab812912f83a104d051c27d 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

@@ -182,10 +182,10 @@ WebInspector.DOMStorageItemsView.prototype = {

_dataGridForDOMStorageItems: function(items)

{

- var columns = [

- {id: "key", title: WebInspector.UIString("Key"), editable: true, weight: 50},

- {id: "value", title: WebInspector.UIString("Value"), editable: true, weight: 50}

- ];

+ var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([

+ {id: "key", title: WebInspector.UIString("Key"), sortable: false, editable: true, weight: 50},

+ {id: "value", title: WebInspector.UIString("Value"), sortable: false, editable: true, weight: 50}

+ ]);

var nodes = [];