[Devtools] Cleanup DataGrid's typecast and identifier naming

third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @param {!WebInspector.TimelineModel} model
  * @param {!Array<!WebInspector.TimelineModel.Filter>} filters
  */
 WebInspector.TimelineTreeView = function(model, filters)
 {
     WebInspector.VBox.call(this);
     this.element.classList.add("timeline-tree-view");
 
     this._model = model;
     this._linkifier = new WebInspector.Linkifier();
 
     this._filters = filters.slice();
 
-    var columns = [];
+    var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([]);
     this._populateColumns(columns);
 
     var mainView = new WebInspector.VBox();
     this._populateToolbar(mainView.element);
     this._dataGrid = new WebInspector.SortableDataGrid(columns);
     this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._sortingChanged, this);
     this._dataGrid.element.addEventListener("mousemove", this._onMouseMove.bind(this), true);
     this._dataGrid.setResizeMethod(WebInspector.DataGrid.ResizeMethod.Last);
     this._dataGrid.asWidget().show(mainView.element);
 
@@ skipping 128 matching lines @@
      */
     _populateColumns: function(columns)
     {
         columns.push({id: "self", title: WebInspector.UIString("Self Time"), width: "110px", fixedWidth: true, sortable: true});
         columns.push({id: "total", title: WebInspector.UIString("Total Time"), width: "110px", fixedWidth: true, sortable: true});
         columns.push({id: "activity", title: WebInspector.UIString("Activity"), disclosure: true, sortable: true});
     },
 
     _sortingChanged: function()
     {
-        var columnIdentifier = this._dataGrid.sortColumnIdentifier();
-        if (!columnIdentifier)
+        var columnId = this._dataGrid.sortColumnId();
+        if (!columnId)
             return;
         var sortFunction;
-        switch (columnIdentifier) {
+        switch (columnId) {
         case "startTime":
             sortFunction = compareStartTime;
             break;
         case "self":
             sortFunction = compareNumericField.bind(null, "selfTime");
             break;
         case "total":
             sortFunction = compareNumericField.bind(null, "totalTime");
             break;
         case "activity":
             sortFunction = compareName;
             break;
         default:
-            console.assert(false, "Unknown sort field: " + columnIdentifier);
+            console.assert(false, "Unknown sort field: " + columnId);
             return;
         }
         this._dataGrid.sortNodes(sortFunction, !this._dataGrid.isSortOrderAscending());
 
         /**
          * @param {string} field
          * @param {!WebInspector.DataGridNode} a
          * @param {!WebInspector.DataGridNode} b
          * @return {number}
          */
@@ skipping 110 matching lines @@
     this._treeView = treeView;
     this._grandTotalTime = grandTotalTime;
     this._maxSelfTime = maxSelfTime;
     this._maxTotalTime = maxTotalTime;
     WebInspector.SortableDataGridNode.call(this, null, false);
 };
 
 WebInspector.TimelineTreeView.GridNode.prototype = {
     /**
      * @override
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    createCell: function(columnIdentifier)
+    createCell: function(columnId)
     {
-        if (columnIdentifier === "activity")
-            return this._createNameCell(columnIdentifier);
-        return this._createValueCell(columnIdentifier) || WebInspector.DataGridNode.prototype.createCell.call(this, columnIdentifier);
+        if (columnId === "activity")
+            return this._createNameCell(columnId);
+        return this._createValueCell(columnId) || WebInspector.DataGridNode.prototype.createCell.call(this, columnId);
     },
 
     /**
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    _createNameCell: function(columnIdentifier)
+    _createNameCell: function(columnId)
     {
-        var cell = this.createTD(columnIdentifier);
+        var cell = this.createTD(columnId);
         var container = cell.createChild("div", "name-container");
         var icon = container.createChild("div", "activity-icon");
         var name = container.createChild("div", "activity-name");
         var event = this._profileNode.event;
         if (this._profileNode.isGroupNode()) {
             var treeView = /** @type {!WebInspector.AggregatedTimelineTreeView} */ (this._treeView);
             var info = treeView._displayInfoForGroupNode(this._profileNode);
             name.textContent = info.name;
             icon.style.backgroundColor = info.color;
         } else if (event) {
             var data = event.args["data"];
             var deoptReason = data && data["deoptReason"];
             if (deoptReason)
                 container.createChild("div", "activity-warning").title = WebInspector.UIString("Not optimized: %s", deoptReason);
             name.textContent = event.name === WebInspector.TimelineModel.RecordType.JSFrame
                 ? WebInspector.beautifyFunctionName(event.args["data"]["functionName"])
                 : WebInspector.TimelineUIUtils.eventTitle(event);
             var link = this._treeView._linkifyLocation(event);
             if (link)
                 container.createChild("div", "activity-link").appendChild(link);
             icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor(event);
         }
         return cell;
     },
 
     /**
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {?Element}
      */
-    _createValueCell: function(columnIdentifier)
+    _createValueCell: function(columnId)
     {
-        if (columnIdentifier !== "self" && columnIdentifier !== "total" && columnIdentifier !== "startTime")
+        if (columnId !== "self" && columnId !== "total" && columnId !== "startTime")
             return null;
 
         var showPercents = false;
         var value;
         var maxTime;
-        switch (columnIdentifier) {
+        switch (columnId) {
         case "startTime":
             value = this._profileNode.event.startTime - this._treeView._model.minimumRecordTime();
             break;
         case "self":
             value = this._profileNode.selfTime;
             maxTime = this._maxSelfTime;
             showPercents = true;
             break;
         case "total":
             value = this._profileNode.totalTime;
             maxTime = this._maxTotalTime;
             showPercents = true;
             break;
         default:
             return null;
         }
-        var cell = this.createTD(columnIdentifier);
+        var cell = this.createTD(columnId);
         cell.className = "numeric-column";
         var textDiv = cell.createChild("div");
         textDiv.createChild("span").textContent = WebInspector.UIString("%.1f\u2009ms", value);
 
         if (showPercents && this._treeView._exposePercentages())
             textDiv.createChild("span", "percent-column").textContent = WebInspector.UIString("%.1f\u2009%%", value / this._grandTotalTime * 100);
         if (maxTime) {
             textDiv.classList.add("background-percent-bar");
             cell.createChild("div", "background-bar-container").createChild("div", "background-bar").style.width = (value * 100 / maxTime).toFixed(1) + "%";
         }
@@ skipping 427 matching lines @@
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.TimelineStackView = function(treeView)
 {
     WebInspector.VBox.call(this);
     var header = this.element.createChild("div", "timeline-stack-view-header");
     header.textContent = WebInspector.UIString("Heaviest stack");
     this._treeView = treeView;
-    var columns = [
+    var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([
         {id: "total", title: WebInspector.UIString("Total Time"), fixedWidth: true, width: "110px"},
         {id: "activity", title: WebInspector.UIString("Activity")}
-    ];
+    ]);
     this._dataGrid = new WebInspector.ViewportDataGrid(columns);
     this._dataGrid.setResizeMethod(WebInspector.DataGrid.ResizeMethod.Last);
     this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._onSelectionChanged, this);
     this._dataGrid.asWidget().show(this.element);
 };
 
 /** @enum {symbol} */
 WebInspector.TimelineStackView.Events = {
     SelectionChanged: Symbol("SelectionChanged")
 };
@@ skipping 27 matching lines @@
         return selectedNode && /** @type {!WebInspector.TimelineTreeView.GridNode} */ (selectedNode)._profileNode;
     },
 
     _onSelectionChanged: function()
     {
         this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.SelectionChanged);
     },
 
     __proto__: WebInspector.VBox.prototype
 };