[Devtools] Cleanup DataGrid's typecast and identifier naming

third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 121 matching lines @@
      */
     _provider: function()
     {
         if (!this._providerObject)
             this._providerObject = this.createProvider();
         return this._providerObject;
     },
 
     /**
      * @override
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    createCell: function(columnIdentifier)
+    createCell: function(columnId)
     {
-        var cell = WebInspector.DataGridNode.prototype.createCell.call(this, columnIdentifier);
+        var cell = WebInspector.DataGridNode.prototype.createCell.call(this, columnId);
         if (this._searchMatched)
             cell.classList.add("highlight");
         return cell;
     },
 
     /**
      * @override
      */
     collapse: function()
     {
@@ skipping 80 matching lines @@
             if (range.from <= nodePosition && nodePosition < range.to) {
                 var childIndex = indexOfFirstChildInRange + nodePosition - range.from;
                 return this.allChildren()[childIndex];
             }
             indexOfFirstChildInRange += range.to - range.from + 1;
         }
         return null;
     },
 
     /**
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    _createValueCell: function(columnIdentifier)
+    _createValueCell: function(columnId)
     {
         var cell = createElement("td");
         cell.className = "numeric-column";
         if (this.dataGrid.snapshot.totalSize !== 0) {
             var div = createElement("div");
             var valueSpan = createElement("span");
-            valueSpan.textContent = this.data[columnIdentifier];
+            valueSpan.textContent = this.data[columnId];
             div.appendChild(valueSpan);
-            var percentColumn = columnIdentifier + "-percent";
+            var percentColumn = columnId + "-percent";
             if (percentColumn in this.data) {
                 var percentSpan = createElement("span");
                 percentSpan.className = "percent-column";
                 percentSpan.textContent = this.data[percentColumn];
                 div.appendChild(percentSpan);
                 div.classList.add("profile-multiple-values");
             }
             cell.appendChild(div);
         }
         return cell;
@@ skipping 266 matching lines @@
      * @override
      * @return {?{snapshot:!WebInspector.HeapSnapshotProxy, snapshotNodeIndex:number}}
      */
     retainersDataSource: function()
     {
         return {snapshot: this._dataGrid.snapshot, snapshotNodeIndex: this.snapshotNodeIndex};
     },
 
     /**
      * @override
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    createCell: function(columnIdentifier)
+    createCell: function(columnId)
     {
-        var cell = columnIdentifier !== "object" ? this._createValueCell(columnIdentifier) : this._createObjectCell();
+        var cell = columnId !== "object" ? this._createValueCell(columnId) : this._createObjectCell();
         if (this._searchMatched)
             cell.classList.add("highlight");
         return cell;
     },
 
     /**
      * @return {!Element}
      */
     _createObjectCell: function()
     {
@@ skipping 210 matching lines @@
     {
         return childNode._edgeIndex;
     },
 
     /**
      * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig}
      */
     comparator: function()
     {
         var sortAscending = this._dataGrid.isSortOrderAscending();
-        var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
+        var sortColumnId = this._dataGrid.sortColumnId();
         var sortFields = {
             object: ["!edgeName", sortAscending, "retainedSize", false],
             count: ["!edgeName", true, "retainedSize", false],
             shallowSize: ["selfSize", sortAscending, "!edgeName", true],
             retainedSize: ["retainedSize", sortAscending, "!edgeName", true],
             distance: ["distance", sortAscending, "_name", true]
-        }[sortColumnIdentifier] || ["!edgeName", true, "retainedSize", false];
+        }[sortColumnId] || ["!edgeName", true, "retainedSize", false];
         return WebInspector.HeapSnapshotGridNode.createComparator(sortFields);
     },
 
     _prefixObjectCell: function(div)
     {
         var name = this._referenceName || "(empty)";
         var nameClass = "name";
         switch (this._referenceType) {
         case "context":
             nameClass = "object-value-number";
@@ skipping 190 matching lines @@
     {
         return childNode._edgeIndex;
     },
 
     /**
      * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig}
      */
     comparator: function()
     {
         var sortAscending = this._dataGrid.isSortOrderAscending();
-        var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
+        var sortColumnId = this._dataGrid.sortColumnId();
         var sortFields = {
             object: ["!edgeName", sortAscending, "retainedSize", false],
             distance: ["distance", sortAscending, "retainedSize", false],
             count: ["!edgeName", true, "retainedSize", false],
             addedSize: ["selfSize", sortAscending, "!edgeName", true],
             removedSize: ["selfSize", sortAscending, "!edgeName", true],
             shallowSize: ["selfSize", sortAscending, "!edgeName", true],
             retainedSize: ["retainedSize", sortAscending, "!edgeName", true]
-        }[sortColumnIdentifier] || ["!edgeName", true, "retainedSize", false];
+        }[sortColumnId] || ["!edgeName", true, "retainedSize", false];
         return WebInspector.HeapSnapshotGridNode.createComparator(sortFields);
     },
 
     __proto__: WebInspector.HeapSnapshotGenericObjectNode.prototype
 };
 
 /**
  * @constructor
  * @param {!WebInspector.HeapSnapshotConstructorsDataGrid} dataGrid
  * @param {string} className
@@ skipping 94 matching lines @@
      * @param {string} filterValue
      * @return {boolean}
      */
     filteredOut: function(filterValue)
     {
         return this._name.toLowerCase().indexOf(filterValue) === -1;
     },
 
     /**
      * @override
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    createCell: function(columnIdentifier)
+    createCell: function(columnId)
     {
-        var cell = columnIdentifier !== "object" ? this._createValueCell(columnIdentifier) : WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnIdentifier);
+        var cell = columnId !== "object" ? this._createValueCell(columnId) : WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnId);
         if (this._searchMatched)
             cell.classList.add("highlight");
         return cell;
     },
 
     /**
      * @param {!WebInspector.HeapSnapshotCommon.Node} item
      * @return {!WebInspector.HeapSnapshotInstanceNode}
      */
     _createChildNode: function(item)
     {
         return new WebInspector.HeapSnapshotInstanceNode(this._dataGrid, this._dataGrid.snapshot, item, false);
     },
 
     /**
      * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig}
      */
     comparator: function()
     {
         var sortAscending = this._dataGrid.isSortOrderAscending();
-        var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
+        var sortColumnId = this._dataGrid.sortColumnId();
         var sortFields = {
             object: ["name", sortAscending, "id", true],
             distance: ["distance", sortAscending, "retainedSize", false],
             count: ["name", true, "id", true],
             shallowSize: ["selfSize", sortAscending, "id", true],
             retainedSize: ["retainedSize", sortAscending, "id", true]
-        }[sortColumnIdentifier];
+        }[sortColumnId];
         return WebInspector.HeapSnapshotGridNode.createComparator(sortFields);
     },
 
     /**
      * @param {!WebInspector.HeapSnapshotCommon.Node} node
      * @return {number}
      */
     _childHashForEntity: function(node)
     {
         return node.id;
@@ skipping 175 matching lines @@
         var tree = this._dataGrid;
         return new WebInspector.HeapSnapshotDiffNodesProvider(
             tree.snapshot.createAddedNodesProvider(tree.baseSnapshot.uid, this._name),
             tree.baseSnapshot.createDeletedNodesProvider(this._deletedIndexes),
             this._addedCount,
             this._removedCount);
     },
 
     /**
      * @override
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    createCell: function(columnIdentifier)
+    createCell: function(columnId)
     {
-        var cell = WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnIdentifier);
-        if (columnIdentifier !== "object")
+        var cell = WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnId);
+        if (columnId !== "object")
             cell.classList.add("numeric-column");
         return cell;
     },
 
     /**
      * @param {!WebInspector.HeapSnapshotCommon.Node} item
      * @return {!WebInspector.HeapSnapshotInstanceNode}
      */
     _createChildNode: function(item)
     {
@@ skipping 20 matching lines @@
     {
         return childNode.snapshotNodeId;
     },
 
     /**
      * @return {!WebInspector.HeapSnapshotCommon.ComparatorConfig}
      */
     comparator: function()
     {
         var sortAscending = this._dataGrid.isSortOrderAscending();
-        var sortColumnIdentifier = this._dataGrid.sortColumnIdentifier();
+        var sortColumnId = this._dataGrid.sortColumnId();
         var sortFields = {
             object: ["name", sortAscending, "id", true],
             addedCount: ["name", true, "id", true],
             removedCount: ["name", true, "id", true],
             countDelta: ["name", true, "id", true],
             addedSize: ["selfSize", sortAscending, "id", true],
             removedSize: ["selfSize", sortAscending, "id", true],
             sizeDelta: ["selfSize", sortAscending, "id", true]
-        }[sortColumnIdentifier];
+        }[sortColumnId];
         return WebInspector.HeapSnapshotGridNode.createComparator(sortFields);
     },
 
     /**
      * @param {string} filterValue
      * @return {boolean}
      */
     filteredOut: function(filterValue)
     {
         return this._name.toLowerCase().indexOf(filterValue) === -1;
@@ skipping 72 matching lines @@
      */
     expand: function()
     {
         WebInspector.HeapSnapshotGridNode.prototype.expand.call(this);
         if (this.children.length === 1)
             this.children[0].expand();
     },
 
     /**
      * @override
-     * @param {string} columnIdentifier
+     * @param {string} columnId
      * @return {!Element}
      */
-    createCell: function(columnIdentifier)
+    createCell: function(columnId)
     {
-        if (columnIdentifier !== "name")
-            return this._createValueCell(columnIdentifier);
+        if (columnId !== "name")
+            return this._createValueCell(columnId);
 
-        var cell = WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnIdentifier);
+        var cell = WebInspector.HeapSnapshotGridNode.prototype.createCell.call(this, columnId);
         var allocationNode = this._allocationNode;
         var target = this._dataGrid.target();
         if (allocationNode.scriptId) {
             var linkifier = this._dataGrid._linkifier;
             var urlElement = linkifier.linkifyScriptLocation(target, String(allocationNode.scriptId), allocationNode.scriptName, allocationNode.line - 1, allocationNode.column - 1, "profile-node-file");
             urlElement.style.maxWidth = "75%";
             cell.insertBefore(urlElement, cell.firstChild);
         }
         return cell;
     },
 
     /**
      * @return {number}
      */
     allocationNodeId: function()
     {
         return this._allocationNode.id;
     },
 
     __proto__: WebInspector.HeapSnapshotGridNode.prototype
 };