Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @param {!WebInspector.NetworkLogView} networkLogView 7 * @param {!WebInspector.NetworkLogView} networkLogView
8 * @param {!WebInspector.Setting} networkLogLargeRowsSetting 8 * @param {!WebInspector.Setting} networkLogLargeRowsSetting
9 */ 9 */
10 WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow sSetting) 10 WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow sSetting)
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 } 447 }
448 }, 448 },
449 449
450 sortByCurrentColumn: function() 450 sortByCurrentColumn: function()
451 { 451 {
452 this._sortHandler(); 452 this._sortHandler();
453 }, 453 },
454 454
455 _sortHandler: function() 455 _sortHandler: function()
456 { 456 {
457 var columnIdentifier = this._dataGrid.sortColumnIdentifier(); 457 var columnId = this._dataGrid.sortColumnId();
458 var columnConfig = this._columns.find(columnConfig => columnConfig.id == = columnIdentifier); 458 var columnConfig = this._columns.find(columnConfig => columnConfig.id == = columnId);
459 if (!columnConfig) 459 if (!columnConfig)
460 return; 460 return;
461 if (columnConfig.sortConfig && columnConfig.sortConfig.entries) { 461 if (columnConfig.sortConfig && columnConfig.sortConfig.entries) {
462 this._sortByDropdownItem(columnConfig); 462 this._sortByDropdownItem(columnConfig);
463 return; 463 return;
464 } 464 }
465 if (!columnConfig.sortConfig.sortingFunction) 465 if (!columnConfig.sortConfig.sortingFunction)
466 return; 466 return;
467 467
468 this._networkLogView.removeAllNodeHighlights(); 468 this._networkLogView.removeAllNodeHighlights();
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 divider.element.classList.toggle("network-frame-divider-selected", f alse); 831 divider.element.classList.toggle("network-frame-divider-selected", f alse);
832 }, 832 },
833 833
834 _updateRowsSize: function() 834 _updateRowsSize: function()
835 { 835 {
836 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) 836 if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
837 return; 837 return;
838 this._timelineGrid.element.classList.toggle("small", !this._networkLogLa rgeRowsSetting.get()); 838 this._timelineGrid.element.classList.toggle("small", !this._networkLogLa rgeRowsSetting.get());
839 } 839 }
840 }; 840 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698