Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 1199
1200 dataGridSorted: function() 1200 dataGridSorted: function()
1201 { 1201 {
1202 this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindM atchIndex(this._currentMatchedRequestNode), false); 1202 this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindM atchIndex(this._currentMatchedRequestNode), false);
1203 1203
1204 if (!Runtime.experiments.isEnabled("canvasNetworkTimeline")) 1204 if (!Runtime.experiments.isEnabled("canvasNetworkTimeline"))
1205 return; 1205 return;
1206 1206
1207 this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-de scending"); 1207 this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-de scending");
1208 1208
1209 if (this._dataGrid.sortColumnIdentifier() === "timeline") { 1209 if (this._dataGrid.sortColumnId() === "timeline") {
1210 if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascen ding) 1210 if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascen ding)
1211 this._timelineColumnSortIcon.classList.add("sort-ascending"); 1211 this._timelineColumnSortIcon.classList.add("sort-ascending");
1212 else 1212 else
1213 this._timelineColumnSortIcon.classList.add("sort-descending"); 1213 this._timelineColumnSortIcon.classList.add("sort-descending");
1214 } 1214 }
1215 1215
1216 this._timelineRequestsAreStale = true; 1216 this._timelineRequestsAreStale = true;
1217 }, 1217 },
1218 1218
1219 /** 1219 /**
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
1895 * @return {boolean} 1895 * @return {boolean}
1896 */ 1896 */
1897 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request) 1897 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request)
1898 { 1898 {
1899 if (request.issueTime() > windowEnd) 1899 if (request.issueTime() > windowEnd)
1900 return false; 1900 return false;
1901 if (request.endTime !== -1 && request.endTime < windowStart) 1901 if (request.endTime !== -1 && request.endTime < windowStart)
1902 return false; 1902 return false;
1903 return true; 1903 return true;
1904 }; 1904 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698