Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 var initialize_HeapSnapshotTest = function() { 1 var initialize_HeapSnapshotTest = function() {
2 2
3 InspectorTest.preloadPanel("profiles"); 3 InspectorTest.preloadPanel("profiles");
4 4
5 InspectorTest.createHeapSnapshotMockFactories = function() { 5 InspectorTest.createHeapSnapshotMockFactories = function() {
6 6
7 InspectorTest.createJSHeapSnapshotMockObject = function() 7 InspectorTest.createJSHeapSnapshotMockObject = function()
8 { 8 {
9 return { 9 return {
10 _rootNodeIndex: 0, 10 _rootNodeIndex: 0,
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 var result = simpleComparator(a, b); 513 var result = simpleComparator(a, b);
514 if (result !== 0 && result !== acceptableComparisonResult) { 514 if (result !== 0 && result !== acceptableComparisonResult) {
515 InspectorTest.addResult("Elements " + i + " and " + (i + 1) + " are out of order: " + a + " " + b + " (" + sortOrder + ")"); 515 InspectorTest.addResult("Elements " + i + " and " + (i + 1) + " are out of order: " + a + " " + b + " (" + sortOrder + ")");
516 } 516 }
517 } 517 }
518 }; 518 };
519 519
520 InspectorTest.clickColumn = function(column, callback) 520 InspectorTest.clickColumn = function(column, callback)
521 { 521 {
522 callback = InspectorTest.safeWrap(callback); 522 callback = InspectorTest.safeWrap(callback);
523 var cell = this._currentGrid()._headerTableHeaders[column.identifier]; 523 var cell = this._currentGrid()._headerTableHeaders[column.id];
524 var event = { target: { enclosingNodeOrSelfWithNodeName: function() { return cell; } } }; 524 var event = { target: { enclosingNodeOrSelfWithNodeName: function() { return cell; } } };
525 525
526 function sortingComplete() 526 function sortingComplete()
527 { 527 {
528 InspectorTest._currentGrid().removeEventListener(WebInspector.HeapSnapsh otSortableDataGrid.Events.SortingComplete, sortingComplete, this); 528 InspectorTest._currentGrid().removeEventListener(WebInspector.HeapSnapsh otSortableDataGrid.Events.SortingComplete, sortingComplete, this);
529 InspectorTest.assertEquals(column.identifier, this._currentGrid().sortCo lumnIdentifier(), "unexpected sorting"); 529 InspectorTest.assertEquals(column.id, this._currentGrid().sortColumnId() , "unexpected sorting");
530 column.sort = this._currentGrid().sortOrder(); 530 column.sort = this._currentGrid().sortOrder();
531 function callCallback() 531 function callCallback()
532 { 532 {
533 callback(column); 533 callback(column);
534 } 534 }
535 setTimeout(callCallback, 0); 535 setTimeout(callCallback, 0);
536 } 536 }
537 InspectorTest._currentGrid().addEventListener(WebInspector.HeapSnapshotSorta bleDataGrid.Events.SortingComplete, sortingComplete, this); 537 InspectorTest._currentGrid().addEventListener(WebInspector.HeapSnapshotSorta bleDataGrid.Events.SortingComplete, sortingComplete, this);
538 this._currentGrid()._clickInHeaderCell(event); 538 this._currentGrid()._clickInHeaderCell(event);
539 }; 539 };
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 function sortingComplete() 727 function sortingComplete()
728 { 728 {
729 dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGr id.Events.SortingComplete, sortingComplete, null); 729 dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGr id.Events.SortingComplete, sortingComplete, null);
730 callback(); 730 callback();
731 } 731 }
732 dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Even ts.SortingComplete, sortingComplete, null); 732 dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Even ts.SortingComplete, sortingComplete, null);
733 } 733 }
734 }; 734 };
735 735
736 }; 736 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698