[Devtools] Cleanup DataGrid's typecast and identifier naming

third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 168 matching lines @@
         this._emptyWidget.detach();
         this._deleteButton.setVisible(true);
 
         // FIXME: For Chrome, put creationTime and updateTime somewhere.
         // NOTE: localizedString has not yet been added.
         // WebInspector.UIString("(%s) Created: %s Updated: %s", this._size, this._creationTime, this._updateTime);
     },
 
     _createDataGrid: function()
     {
-        var columns = [
-            {title: WebInspector.UIString("Resource"), sort: WebInspector.DataGrid.Order.Ascending, sortable: true},
-            {title: WebInspector.UIString("Type"), sortable: true},
-            {title: WebInspector.UIString("Size"), align: WebInspector.DataGrid.Align.Right, sortable: true}
-        ];
+        var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([
+            {id: "resource", title: WebInspector.UIString("Resource"), sort: WebInspector.DataGrid.Order.Ascending, sortable: true},
+            {id: "type", title: WebInspector.UIString("Type"), sortable: true},
+            {id: "size", title: WebInspector.UIString("Size"), align: WebInspector.DataGrid.Align.Right, sortable: true}
+        ]);
         this._dataGrid = new WebInspector.DataGrid(columns);
         this._dataGrid.asWidget().show(this.element);
         this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._populateDataGrid, this);
     },
 
     _populateDataGrid: function()
     {
         var selectedResource = this._dataGrid.selectedNode ? this._dataGrid.selectedNode.resource : null;
         var sortDirection = this._dataGrid.isSortOrderAscending() ? 1 : -1;
 
         function numberCompare(field, resource1, resource2)
         {
             return sortDirection * (resource1[field] - resource2[field]);
         }
         function localeCompare(field, resource1, resource2)
         {
             return sortDirection * (resource1[field] + "").localeCompare(resource2[field] + "");
         }
 
         var comparator;
-        switch (parseInt(this._dataGrid.sortColumnIdentifier(), 10)) {
+        switch (parseInt(this._dataGrid.sortColumnId(), 10)) {

[dgozman, 2016/10/25 18:42:40]

Compare to new ids instead.

[allada, 2016/10/25 18:56:14]

Done.

         case 0: comparator = localeCompare.bind(null, "name"); break;
         case 1: comparator = localeCompare.bind(null, "type"); break;
         case 2: comparator = numberCompare.bind(null, "size"); break;
         default: localeCompare.bind(null, "resource"); // FIXME: comparator = ?
         }
 
         this._resources.sort(comparator);
         this._dataGrid.rootNode().removeChildren();
 
         var nodeToSelect;
@@ skipping 29 matching lines @@
     _deleteCallback: function(node)
     {
         // FIXME: Should we delete a single (selected) resource or all resources?
         // InspectorBackend.deleteCachedResource(...)
         // this._update();
     },
 
     __proto__: WebInspector.SimpleView.prototype
 }