[Devtools] Cleanup DataGrid's typecast and identifier naming

third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {WebInspector.Searchable}
  * @extends {WebInspector.SimpleView}
  * @param {!WebInspector.ProfileDataGridNode.Formatter} nodeFormatter
  * @param {!Array<string>=} viewTypes
  */
 WebInspector.ProfileView = function(nodeFormatter, viewTypes)
 {
     WebInspector.SimpleView.call(this, WebInspector.UIString("Profile"));
 
     this._searchableView = new WebInspector.SearchableView(this);
     this._searchableView.setPlaceholder(WebInspector.UIString("Find by cost (>50ms), name or file"));
     this._searchableView.show(this.element);
 
     viewTypes = viewTypes || [
         WebInspector.ProfileView.ViewTypes.Flame,
         WebInspector.ProfileView.ViewTypes.Heavy,
         WebInspector.ProfileView.ViewTypes.Tree
     ];
     this._viewType = WebInspector.settings.createSetting("profileView", WebInspector.ProfileView.ViewTypes.Heavy);
     this._nodeFormatter = nodeFormatter;
 
-    var columns = [];
+    var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([]);
     columns.push({id: "self", title: this.columnHeader("self"), width: "120px", fixedWidth: true, sortable: true, sort: WebInspector.DataGrid.Order.Descending});
     columns.push({id: "total", title: this.columnHeader("total"), width: "120px", fixedWidth: true, sortable: true});
     columns.push({id: "function", title: WebInspector.UIString("Function"), disclosure: true, sortable: true});
 
     this.dataGrid = new WebInspector.DataGrid(columns);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._sortProfile, this);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._nodeSelected.bind(this, true));
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.DeselectedNode, this._nodeSelected.bind(this, false));
 
     this.viewSelectComboBox = new WebInspector.ToolbarComboBox(this._changeView.bind(this));
@@ skipping 329 matching lines @@
         this.resetButton.setEnabled(false);
         this.profileDataGridTree.restore();
         this._linkifier.reset();
         this.refresh();
         this.refreshVisibleData();
     },
 
     _sortProfile: function()
     {
         var sortAscending = this.dataGrid.isSortOrderAscending();
-        var sortColumnIdentifier = this.dataGrid.sortColumnIdentifier();
-        var sortProperty = sortColumnIdentifier === "function" ? "functionName" : sortColumnIdentifier || "";
+        var sortColumnId = this.dataGrid.sortColumnId();
+        var sortProperty = sortColumnId === "function" ? "functionName" : sortColumnId || "";
         this.profileDataGridTree.sort(WebInspector.ProfileDataGridTree.propertyComparator(sortProperty, sortAscending));
 
         this.refresh();
     },
 
     __proto__: WebInspector.SimpleView.prototype
 }
 
 /**
  * @constructor
@@ skipping 209 matching lines @@
     _notifyTempFileReady: function()
     {
         if (this._onTempFileReady) {
             this._onTempFileReady();
             this._onTempFileReady = null;
         }
     },
 
     __proto__: WebInspector.ProfileHeader.prototype
 }