Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1144 matching lines...) Expand 10 before | Expand all | Expand 10 after
1155 1155
1156 dataGridSorted: function() 1156 dataGridSorted: function()
1157 { 1157 {
1158 this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindM atchIndex(this._currentMatchedRequestNode), false); 1158 this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindM atchIndex(this._currentMatchedRequestNode), false);
1159 1159
1160 if (!Runtime.experiments.isEnabled("canvasNetworkTimeline")) 1160 if (!Runtime.experiments.isEnabled("canvasNetworkTimeline"))
1161 return; 1161 return;
1162 1162
1163 this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-de scending"); 1163 this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-de scending");
1164 1164
1165 if (this._dataGrid.sortColumnIdentifier() === "timeline") { 1165 if (this._dataGrid.sortColumnId() === "timeline") {
1166 if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascen ding) 1166 if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascen ding)
1167 this._timelineColumnSortIcon.classList.add("sort-ascending"); 1167 this._timelineColumnSortIcon.classList.add("sort-ascending");
1168 else 1168 else
1169 this._timelineColumnSortIcon.classList.add("sort-descending"); 1169 this._timelineColumnSortIcon.classList.add("sort-descending");
1170 } 1170 }
1171 1171
1172 this._timelineColumn.scheduleRefreshData(); 1172 this._timelineColumn.scheduleRefreshData();
1173 }, 1173 },
1174 1174
1175 /** 1175 /**
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
1851 * @return {boolean} 1851 * @return {boolean}
1852 */ 1852 */
1853 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request) 1853 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request)
1854 { 1854 {
1855 if (request.issueTime() > windowEnd) 1855 if (request.issueTime() > windowEnd)
1856 return false; 1856 return false;
1857 if (request.endTime !== -1 && request.endTime < windowStart) 1857 if (request.endTime !== -1 && request.endTime < windowStart)
1858 return false; 1858 return false;
1859 return true; 1859 return true;
1860 } 1860 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698