Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2444193008: Revert of Disabling WorkerProcessLauncherTest.Crash (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
Sam McNally, Nico
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabling WorkerProcessLauncherTest.Crash (patchset #1 id:1 of https://codereview.chromium.org/2450063002/ ) Reason for revert: Re-enabling now that "Use ChannelMojo between the remoting daemon and network processes" is reverted ( https://codereview.chromium.org/2424353002/) http://crbug.com/659219 Original issue's description: > Disabling WorkerProcessLauncherTest.Crash > > It's failing on Win dbg bots > > BUG=659219 > TBR=sammc@chromium.org > NOTRY=true > > Committed: https://crrev.com/4af028e242ed5275e2241f291df47557ec57101b > Cr-Commit-Position: refs/heads/master@{#427493} TBR=sammc@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659219 Committed: https://crrev.com/eca3c23df63fc990a8e65f5249a4b8d1a5ce296b Cr-Commit-Position: refs/heads/master@{#427811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M remoting/host/win/worker_process_launcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dmazzoni
Created Revert of Disabling WorkerProcessLauncherTest.Crash
4 years, 1 month ago (2016-10-26 21:31:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444193008/1
4 years, 1 month ago (2016-10-26 21:32:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 21:33:48 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:36:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eca3c23df63fc990a8e65f5249a4b8d1a5ce296b
Cr-Commit-Position: refs/heads/master@{#427811}

Powered by Google App Engine
This is Rietveld 408576698