Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2444193003: Replace VLOG(0) with VLOG(1) in accessibility code (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace VLOG(0) with VLOG(1) in accessibility code VLOG(0) is the same as LOG(INFO) which is pretty spammy by default, and DVLOG is only available in debug builds. Replace with VLOG(1) for two cases of files where we don't want logging by default but where it's useful to have the option to enable logging for a release build. BUG=653715 Committed: https://crrev.com/ab6b47da9faa24b7e356d493ce21b940ba16fbca Cr-Commit-Position: refs/heads/master@{#427399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M content/renderer/accessibility/render_accessibility_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 10 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dmazzoni
4 years, 1 month ago (2016-10-25 06:44:32 UTC) #2
nektarios
On 2016/10/25 at 06:44:32, dmazzoni wrote: > I think it would be more clear if ...
4 years, 1 month ago (2016-10-25 15:04:58 UTC) #3
nektarios
lgtm
4 years, 1 month ago (2016-10-25 15:05:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444193003/1
4 years, 1 month ago (2016-10-25 16:44:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:39:17 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:43:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab6b47da9faa24b7e356d493ce21b940ba16fbca
Cr-Commit-Position: refs/heads/master@{#427399}

Powered by Google App Engine
This is Rietveld 408576698