Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2444193002: Helium: Fix flaky test (Closed)

Created:
4 years, 1 month ago by scf
Modified:
4 years, 1 month ago
Reviewers:
steimel, xyzzyz, Kevin M, CJ
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Helium: Fix flaky test Unit test fixture was not using HeliumTest test fixture and thus not properly cleaning state. BUG=658798 Committed: https://crrev.com/1ce5fa0395e29192dcefe6d3211d947b32968d40 Cr-Commit-Position: refs/heads/master@{#427387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M blimp/helium/compound_syncable_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
scf
4 years, 1 month ago (2016-10-25 16:28:12 UTC) #3
Kevin M
lgtm Thanks!
4 years, 1 month ago (2016-10-25 17:00:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444193002/1
4 years, 1 month ago (2016-10-25 17:01:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:16:25 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:18:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ce5fa0395e29192dcefe6d3211d947b32968d40
Cr-Commit-Position: refs/heads/master@{#427387}

Powered by Google App Engine
This is Rietveld 408576698